2008-06-02 09:33:12

by Adrian-Ken Rueegsegger

[permalink] [raw]
Subject: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

This patch makes HMAC-RIPEMD-160 usable with IPsec/XFRM. The RIPEMD-160
implementation is currently in the cryptodev-2.6 tree.

Since I have no IPsec test setup the patch has not (yet) been tested with
IPsec and is thus marked as RFC. I will put together a test environment which
will take some time. In the meantime it would be great if somebody who already
has a working IPsec environment could test this patch.

Thanks,
Adrian



2008-06-02 09:33:12

by Adrian-Ken Rueegsegger

[permalink] [raw]
Subject: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn
allows hmac(rmd160) to be used as authentication mechanism in IPsec
ESP and AH (see RFC 2857).

Signed-off-by: Adrian-Ken Rueegsegger <[email protected]>
---
net/xfrm/xfrm_algo.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/xfrm/xfrm_algo.c b/net/xfrm/xfrm_algo.c
index ac765dd..23a2cc0 100644
--- a/net/xfrm/xfrm_algo.c
+++ b/net/xfrm/xfrm_algo.c
@@ -200,8 +200,8 @@ static struct xfrm_algo_desc aalg_list[] = {
}
},
{
- .name = "hmac(ripemd160)",
- .compat = "ripemd160",
+ .name = "hmac(rmd160)",
+ .compat = "rmd160",

.uinfo = {
.auth = {
--
1.5.2.5


2008-06-02 10:41:07

by Herbert Xu

[permalink] [raw]
Subject: Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

On Mon, Jun 02, 2008 at 11:33:09AM +0200, Adrian-Ken Rueegsegger wrote:
> This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn
> allows hmac(rmd160) to be used as authentication mechanism in IPsec
> ESP and AH (see RFC 2857).
>
> Signed-off-by: Adrian-Ken Rueegsegger <[email protected]>

Acked-by: Herbert Xu <[email protected]>
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2008-06-04 19:05:04

by David Miller

[permalink] [raw]
Subject: Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

From: Herbert Xu <[email protected]>
Date: Mon, 2 Jun 2008 20:41:07 +1000

> On Mon, Jun 02, 2008 at 11:33:09AM +0200, Adrian-Ken Rueegsegger wrote:
> > This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn
> > allows hmac(rmd160) to be used as authentication mechanism in IPsec
> > ESP and AH (see RFC 2857).
> >
> > Signed-off-by: Adrian-Ken Rueegsegger <[email protected]>
>
> Acked-by: Herbert Xu <[email protected]>

Applied, thanks everyone.