On Thu, Jul 03, 2008 at 02:03:57PM -0700, Harvey Harrison wrote:
> Remove the private implementation of 32-bit rotation and unaligned
> access with byteswapping.
>
> As a bonus, fixes sparse warnings:
> crypto/camellia.c:602:2: warning: cast to restricted __be32
> crypto/camellia.c:603:2: warning: cast to restricted __be32
> crypto/camellia.c:604:2: warning: cast to restricted __be32
> crypto/camellia.c:605:2: warning: cast to restricted __be32
> crypto/camellia.c:710:2: warning: cast to restricted __be32
> crypto/camellia.c:711:2: warning: cast to restricted __be32
> crypto/camellia.c:712:2: warning: cast to restricted __be32
> crypto/camellia.c:713:2: warning: cast to restricted __be32
> crypto/camellia.c:714:2: warning: cast to restricted __be32
> crypto/camellia.c:715:2: warning: cast to restricted __be32
> crypto/camellia.c:716:2: warning: cast to restricted __be32
> crypto/camellia.c:717:2: warning: cast to restricted __be32
>
> Signed-off-by: Harvey Harrison <[email protected]>
Patch applied. BTW, this driver should perhaps use align mask
instead rather than handling unaligned data on its own.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Fri, Jul 04, 2008 at 07:43:15PM +0800, Herbert Xu wrote:
> On Thu, Jul 03, 2008 at 02:03:57PM -0700, Harvey Harrison wrote:
> > Remove the private implementation of 32-bit rotation and unaligned
> > access with byteswapping.
> >
> > As a bonus, fixes sparse warnings:
> > crypto/camellia.c:602:2: warning: cast to restricted __be32
> > crypto/camellia.c:603:2: warning: cast to restricted __be32
> > crypto/camellia.c:604:2: warning: cast to restricted __be32
> > crypto/camellia.c:605:2: warning: cast to restricted __be32
> > crypto/camellia.c:710:2: warning: cast to restricted __be32
> > crypto/camellia.c:711:2: warning: cast to restricted __be32
> > crypto/camellia.c:712:2: warning: cast to restricted __be32
> > crypto/camellia.c:713:2: warning: cast to restricted __be32
> > crypto/camellia.c:714:2: warning: cast to restricted __be32
> > crypto/camellia.c:715:2: warning: cast to restricted __be32
> > crypto/camellia.c:716:2: warning: cast to restricted __be32
> > crypto/camellia.c:717:2: warning: cast to restricted __be32
> >
> > Signed-off-by: Harvey Harrison <[email protected]>
>
> Patch applied. BTW, this driver should perhaps use align mask
> instead rather than handling unaligned data on its own.
Hmm, camellia is now failing the tcrypt self-test. Harvey,
could you have a look at this?
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt