2008-09-22 19:29:37

by Neil Horman

Subject: [PATCH] trigger a panic when operating in FIPS mode and a crypto self test fails.

Hey all-
The FIPS specification requires that should self test for any supported
crypto algorithm fail during operation in fips mode, we need to prevent the use
of any crypto functionality until such time as the system can be re-initialized.
Seems like the best way to handle that would be to panic the system if we were
in fips mode and failed a self test. This patch implements that functionality.
I've built and run it successfully with and

Regards
Neil

Signed-off-by: Neil Horman <[email protected]>


testmgr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index b828c6c..a55cd14 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -1801,6 +1801,7 @@ static int alg_find_test(const char *alg)
int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
{
int i;
+ int rc;

if ((type & CRYPTO_ALG_TYPE_MASK) == CRYPTO_ALG_TYPE_CIPHER) {
char nalg[CRYPTO_MAX_ALG_NAME];
@@ -1820,8 +1821,12 @@ int alg_test(const char *driver, const char *alg, u32 type, u32 mask)
if (i < 0)
goto notest;

- return alg_test_descs[i].test(alg_test_descs + i, driver,
+ rc = alg_test_descs[i].test(alg_test_descs + i, driver,
type, mask);
+ if (fips_enabled && rc)
+ panic("%s: %s alg self test failed in fips mode!\n", driver, alg);
+
+ return rc;

notest:
printk(KERN_INFO "alg: No test for %s (%s)\n", alg, driver);
--
/****************************************************
* Neil Horman <[email protected]>
* Software Engineer, Red Hat
****************************************************/

2008-10-12 12:38:26

by Herbert Xu

Subject: Re: [PATCH] trigger a panic when operating in FIPS mode and a crypto self test fails.

On Mon, Sep 22, 2008 at 03:27:27PM -0400, Neil Horman wrote:
> Hey all-
> The FIPS specification requires that should self test for any supported
> crypto algorithm fail during operation in fips mode, we need to prevent the use
> of any crypto functionality until such time as the system can be re-initialized.
> Seems like the best way to handle that would be to panic the system if we were
> in fips mode and failed a self test. This patch implements that functionality.
> I've built and run it successfully with and

Patch applied. Thanks Neil!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt