2012-01-09 16:29:03

by Kim Phillips

[permalink] [raw]
Subject: [PATCH] crypto: caam - fix gcc 4.6 warning

drivers/crypto/caam/ctrl.c: In function 'caam_probe':
drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' [-Wunused-variable]

Signed-off-by: Kim Phillips <[email protected]>
---
drivers/crypto/caam/ctrl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 8ae3ba2..c5f61c5 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -46,7 +46,7 @@ static int caam_remove(struct platform_device *pdev)
/* Probe routine for CAAM top (controller) level */
static int caam_probe(struct platform_device *pdev)
{
- int d, ring, rspec;
+ int ring, rspec;
struct device *dev;
struct device_node *nprop, *np;
struct caam_ctrl __iomem *ctrl;
--
1.7.8.3


2012-01-13 05:39:21

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: caam - fix gcc 4.6 warning

On Mon, Jan 09, 2012 at 10:27:40AM -0600, Kim Phillips wrote:
> drivers/crypto/caam/ctrl.c: In function 'caam_probe':
> drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' [-Wunused-variable]
>
> Signed-off-by: Kim Phillips <[email protected]>

Both patches applied.

Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2012-01-19 00:36:19

by Kim Phillips

[permalink] [raw]
Subject: Re: [PATCH] crypto: caam - fix gcc 4.6 warning

On Fri, 13 Jan 2012 16:39:18 +1100
Herbert Xu <[email protected]> wrote:

> On Mon, Jan 09, 2012 at 10:27:40AM -0600, Kim Phillips wrote:
> > drivers/crypto/caam/ctrl.c: In function 'caam_probe':
> > drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' [-Wunused-variable]
> >
> > Signed-off-by: Kim Phillips <[email protected]>
>
> Both patches applied.

Hi Herbert, I see you've applied:

e863f9c crypto: caam - add sha224 and sha384 variants to existing AEAD algorithm
0113529 crypto: caam - be less noisy on startup

to the cryptodev tree, but not the one at the start of this thread,
which needs to go into your crypto tree (it's a fix for v3.3). I'm
resending it below in case it was lost.

Thanks,

Kim

>From 3b85bc6b93ff561d9d9f85b455734eb26487e875 Mon Sep 17 00:00:00 2001
From: Kim Phillips <[email protected]>
Date: Tue, 20 Dec 2011 18:24:30 -0600
Subject: [PATCH] crypto: caam - fix gcc 4.6 warning

drivers/crypto/caam/ctrl.c: In function 'caam_probe':
drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' [-Wunused-variable]

Signed-off-by: Kim Phillips <[email protected]>
---
drivers/crypto/caam/ctrl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 8ae3ba2..c5f61c5 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -46,7 +46,7 @@ static int caam_remove(struct platform_device *pdev)
/* Probe routine for CAAM top (controller) level */
static int caam_probe(struct platform_device *pdev)
{
- int d, ring, rspec;
+ int ring, rspec;
struct device *dev;
struct device_node *nprop, *np;
struct caam_ctrl __iomem *ctrl;
--
1.7.8.3

2012-01-26 02:37:59

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: caam - fix gcc 4.6 warning

On Wed, Jan 18, 2012 at 06:34:34PM -0600, Kim Phillips wrote:
> On Fri, 13 Jan 2012 16:39:18 +1100
> Herbert Xu <[email protected]> wrote:
>
> > On Mon, Jan 09, 2012 at 10:27:40AM -0600, Kim Phillips wrote:
> > > drivers/crypto/caam/ctrl.c: In function 'caam_probe':
> > > drivers/crypto/caam/ctrl.c:49:6: warning: unused variable 'd' [-Wunused-variable]
> > >
> > > Signed-off-by: Kim Phillips <[email protected]>
> >
> > Both patches applied.
>
> Hi Herbert, I see you've applied:
>
> e863f9c crypto: caam - add sha224 and sha384 variants to existing AEAD algorithm
> 0113529 crypto: caam - be less noisy on startup
>
> to the cryptodev tree, but not the one at the start of this thread,
> which needs to go into your crypto tree (it's a fix for v3.3). I'm
> resending it below in case it was lost.

I've applied it to cryptodev as I don't think this is important
enough to warrant going into crypto right away.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt