2012-08-23 22:46:48

by Ben Collins

[permalink] [raw]
Subject: [PATCH] crypto/caam: Export gen_split_key symbol for other modules

In 3.6-rc3, without this patch, the following error occurs with a modular build:

ERROR: "gen_split_key" [drivers/crypto/caam/caamhash.ko] undefined!
ERROR: "gen_split_key" [drivers/crypto/caam/caamalg.ko] undefined!

Signed-off-by: Ben Collins <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: Yuan Kang <[email protected]>

diff --git a/drivers/crypto/caam/key_gen.c b/drivers/crypto/caam/key_gen.c
index 0028881..d216cd3 100644
--- a/drivers/crypto/caam/key_gen.c
+++ b/drivers/crypto/caam/key_gen.c
@@ -120,3 +120,4 @@ u32 gen_split_key(struct device *jrdev, u8 *key_out, int split_key_len,

return ret;
}
+EXPORT_SYMBOL(gen_split_key);

--
Ben Collins
Servergy, Inc.


2012-08-24 23:38:30

by Kim Phillips

[permalink] [raw]
Subject: Re: [PATCH] crypto/caam: Export gen_split_key symbol for other modules

On Thu, 23 Aug 2012 18:39:57 -0400
Ben Collins <[email protected]> wrote:

> In 3.6-rc3, without this patch, the following error occurs with a modular build:
>
> ERROR: "gen_split_key" [drivers/crypto/caam/caamhash.ko] undefined!
> ERROR: "gen_split_key" [drivers/crypto/caam/caamalg.ko] undefined!
>
> Signed-off-by: Ben Collins <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: Yuan Kang <[email protected]>

Acked-by: Kim Phillips <[email protected]>

Kim

2012-09-06 20:11:52

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto/caam: Export gen_split_key symbol for other modules

On Fri, Aug 24, 2012 at 06:35:50PM -0500, Kim Phillips wrote:
> On Thu, 23 Aug 2012 18:39:57 -0400
> Ben Collins <[email protected]> wrote:
>
> > In 3.6-rc3, without this patch, the following error occurs with a modular build:
> >
> > ERROR: "gen_split_key" [drivers/crypto/caam/caamhash.ko] undefined!
> > ERROR: "gen_split_key" [drivers/crypto/caam/caamalg.ko] undefined!
> >
> > Signed-off-by: Ben Collins <[email protected]>
> > Cc: Herbert Xu <[email protected]>
> > Cc: Yuan Kang <[email protected]>
>
> Acked-by: Kim Phillips <[email protected]>

Patch applied to crypto. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt