2012-11-13 01:52:33

by Shan Wei

Subject: [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper

From: Shan Wei <[email protected]>

For bottom halves off, __this_cpu_read is better.

Signed-off-by: Shan Wei <[email protected]>
Reviewed-by: Christoph Lameter <[email protected]>
---
no changes vs v4.
---
kernel/padata.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 89fe3d1..072f4ee 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -171,7 +171,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
{
int cpu, num_cpus;
unsigned int next_nr, next_index;
- struct padata_parallel_queue *queue, *next_queue;
+ struct padata_parallel_queue *next_queue;
struct padata_priv *padata;
struct padata_list *reorder;

@@ -204,8 +204,7 @@ static struct padata_priv *padata_get_next(struct parallel_data *pd)
goto out;
}

- queue = per_cpu_ptr(pd->pqueue, smp_processor_id());
- if (queue->cpu_index == next_queue->cpu_index) {
+ if (__this_cpu_read(pd->pqueue->cpu_index) == next_queue->cpu_index) {
padata = ERR_PTR(-ENODATA);
goto out;
}
--
1.7.1

2012-11-13 07:27:03

by Steffen Klassert

Subject: Re: [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper

On Tue, Nov 13, 2012 at 09:52:33AM +0800, Shan Wei wrote:
> From: Shan Wei <[email protected]>
>
> For bottom halves off, __this_cpu_read is better.
>
> Signed-off-by: Shan Wei <[email protected]>
> Reviewed-by: Christoph Lameter <[email protected]>

Acked-by: Steffen Klassert <[email protected]>

Herbert, are you going to take this one?

2012-11-13 07:36:33

by Herbert Xu

Subject: Re: [PATCH v4 5/9] kernel: padata : use __this_cpu_read per-cpu helper

On Tue, Nov 13, 2012 at 08:27:03AM +0100, Steffen Klassert wrote:
> On Tue, Nov 13, 2012 at 09:52:33AM +0800, Shan Wei wrote:
> > From: Shan Wei <[email protected]>
> >
> > For bottom halves off, __this_cpu_read is better.
> >
> > Signed-off-by: Shan Wei <[email protected]>
> > Reviewed-by: Christoph Lameter <[email protected]>
>
> Acked-by: Steffen Klassert <[email protected]>
>
> Herbert, are you going to take this one?

Thanks Steffen, I'll apply his patch.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt