The Kconfig entry for CAAM's hash algorithm implementations has always
selected CRYPTO_AHASH. But there's no corresponding Kconfig symbol.
It seems it was intended to select CRYPTO_HASH, like other crypto
drivers do. That would apparently (indirectly) select CRYPTO_HASH2,
which would enable the ahash functionality this driver uses.
Signed-off-by: Paul Bolle <[email protected]>
---
0) Untested!
1) Apparently, one can indirectly select a Kconfig symbol. That actually
surprised me. But if the kconfig parser does not work this way this
patch (and it's explanation) is bogus.
drivers/crypto/caam/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig
index 65c7668..b44091c 100644
--- a/drivers/crypto/caam/Kconfig
+++ b/drivers/crypto/caam/Kconfig
@@ -78,7 +78,7 @@ config CRYPTO_DEV_FSL_CAAM_AHASH_API
tristate "Register hash algorithm implementations with Crypto API"
depends on CRYPTO_DEV_FSL_CAAM
default y
- select CRYPTO_AHASH
+ select CRYPTO_HASH
help
Selecting this will offload ahash for users of the
scatterlist crypto API to the SEC4 via job ring.
--
1.7.11.7
On Tue, 5 Mar 2013 14:33:16 +0100
Paul Bolle <[email protected]> wrote:
> The Kconfig entry for CAAM's hash algorithm implementations has always
> selected CRYPTO_AHASH. But there's no corresponding Kconfig symbol.
>
> It seems it was intended to select CRYPTO_HASH, like other crypto
> drivers do. That would apparently (indirectly) select CRYPTO_HASH2,
> which would enable the ahash functionality this driver uses.
>
> Signed-off-by: Paul Bolle <[email protected]>
> ---
Reviewed-by: Kim Phillips <[email protected]>
Kim
On Thu, Mar 07, 2013 at 06:51:27PM -0600, Kim Phillips wrote:
> On Tue, 5 Mar 2013 14:33:16 +0100
> Paul Bolle <[email protected]> wrote:
>
> > The Kconfig entry for CAAM's hash algorithm implementations has always
> > selected CRYPTO_AHASH. But there's no corresponding Kconfig symbol.
> >
> > It seems it was intended to select CRYPTO_HASH, like other crypto
> > drivers do. That would apparently (indirectly) select CRYPTO_HASH2,
> > which would enable the ahash functionality this driver uses.
> >
> > Signed-off-by: Paul Bolle <[email protected]>
> > ---
>
> Reviewed-by: Kim Phillips <[email protected]>
Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt