2013-05-14 04:23:06

by Herbert Xu

[permalink] [raw]
Subject: Re: [cryptodev:master 2/13] undefined reference to `crypto_shash_update'

On Tue, May 14, 2013 at 12:11:19PM +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: b9d0b63e0349515938e42f85f9e7a1742ae919d1
> commit: f8ef7e01fe6ec9ffc0cef1044d385acb590ac106 [2/13] crypto: crct10dif - Wrap crc_t10dif function all to use crypto transform framework
> config: i386-randconfig-x10-0513 (attached as .config)
>
> All error/warnings:
>
> lib/built-in.o: In function `crc_t10dif':
> >> (.text+0x1047a): undefined reference to `crypto_shash_update'
> lib/built-in.o: In function `crc_t10dif_update_lib':
> >> (.text+0x104b6): undefined reference to `crypto_alloc_shash'
> lib/built-in.o: In function `crc_t10dif_update_lib':
> >> (.text+0x1052e): undefined reference to `crypto_destroy_tfm'
> lib/built-in.o: In function `crc_t10dif_update_lib':
> >> (.text+0x10540): undefined reference to `crypto_destroy_tfm'
> lib/built-in.o: In function `crc_t10dif_mod_fini':
> >> crc-t10dif.c:(.exit.text+0x10): undefined reference to `crypto_destroy_tfm'

Thanks. Should be fixed by the following patch which I've foloded
into the original changes.

diff --git a/lib/Kconfig b/lib/Kconfig
index fe01d41..0cee056 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -63,6 +63,7 @@ config CRC16

config CRC_T10DIF
tristate "CRC calculation for the T10 Data Integrity Field"
+ select CRYPTO_CRCT10DIF
help
This option is only needed if a module that's not in the
kernel tree needs to calculate CRC checks for use with the

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt