2013-06-03 21:57:21

by Arnd Bergmann

Subject: [PATCH] crypto: sahara: fix building as module

The sahara crypto driver has an incorrect MODULE_DEVICE_TABLE, which
prevents us from actually building this driver as a loadable module.

sahara_dt_ids is a of_device_id array, so we have to use
MODULE_DEVICE_TABLE(of, ...).

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Javier Martin <[email protected]>
Cc: Herbert Xu <[email protected]>

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index a97bb6c..c3dc1c0 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -863,7 +863,7 @@ static struct of_device_id sahara_dt_ids[] = {
{ .compatible = "fsl,imx27-sahara" },
{ /* sentinel */ }
};
-MODULE_DEVICE_TABLE(platform, sahara_dt_ids);
+MODULE_DEVICE_TABLE(of, sahara_dt_ids);

static int sahara_probe(struct platform_device *pdev)
{

2013-06-05 08:42:21

by Herbert Xu

Subject: Re: [PATCH] crypto: sahara: fix building as module

On Mon, Jun 03, 2013 at 11:57:37PM +0200, Arnd Bergmann wrote:
> The sahara crypto driver has an incorrect MODULE_DEVICE_TABLE, which
> prevents us from actually building this driver as a loadable module.
>
> sahara_dt_ids is a of_device_id array, so we have to use
> MODULE_DEVICE_TABLE(of, ...).
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Javier Martin <[email protected]>
> Cc: Herbert Xu <[email protected]>

Patch applied to crypto. Thanks!
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt