2013-09-03 13:36:04

by Jussi Kivilinna

[permalink] [raw]
Subject: [PATCH] crypto: sha256_ssse3 - use correct module alias for sha224

Commit a710f761f (crypto: sha256_ssse3 - add sha224 support) attempted to add
MODULE_ALIAS for SHA-224, but it ended up being "sha384", probably because
mix-up with previous commit 340991e30 (crypto: sha512_ssse3 - add sha384
support). Patch corrects module alias to "sha224".

Reported-by: Pierre-Mayeul Badaire <[email protected]>
Signed-off-by: Jussi Kivilinna <[email protected]>
---
arch/x86/crypto/sha256_ssse3_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/crypto/sha256_ssse3_glue.c b/arch/x86/crypto/sha256_ssse3_glue.c
index 50226c4..85021a4 100644
--- a/arch/x86/crypto/sha256_ssse3_glue.c
+++ b/arch/x86/crypto/sha256_ssse3_glue.c
@@ -319,4 +319,4 @@ MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("SHA256 Secure Hash Algorithm, Supplemental SSE3 accelerated");

MODULE_ALIAS("sha256");
-MODULE_ALIAS("sha384");
+MODULE_ALIAS("sha224");


2013-09-13 12:22:51

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: sha256_ssse3 - use correct module alias for sha224

On Tue, Sep 03, 2013 at 04:26:49PM +0300, Jussi Kivilinna wrote:
> Commit a710f761f (crypto: sha256_ssse3 - add sha224 support) attempted to add
> MODULE_ALIAS for SHA-224, but it ended up being "sha384", probably because
> mix-up with previous commit 340991e30 (crypto: sha512_ssse3 - add sha384
> support). Patch corrects module alias to "sha224".
>
> Reported-by: Pierre-Mayeul Badaire <[email protected]>
> Signed-off-by: Jussi Kivilinna <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt