2014-06-23 16:39:23

by Jussi Kivilinna

Subject: [PATCH] crypto: des3_ede/x86-64: fix parse warning

Patch fixes following sparse warning:

CHECK arch/x86/crypto/des3_ede_glue.c
arch/x86/crypto/des3_ede_glue.c:308:52: warning: restricted __be64 degrades to integer
arch/x86/crypto/des3_ede_glue.c:309:52: warning: restricted __be64 degrades to integer
arch/x86/crypto/des3_ede_glue.c:310:52: warning: restricted __be64 degrades to integer
arch/x86/crypto/des3_ede_glue.c:326:44: warning: restricted __be64 degrades to integer

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Jussi Kivilinna <[email protected]>
---
arch/x86/crypto/des3_ede_glue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede_glue.c
index ebc4215..0e9c066 100644
--- a/arch/x86/crypto/des3_ede_glue.c
+++ b/arch/x86/crypto/des3_ede_glue.c
@@ -289,8 +289,8 @@ static unsigned int __ctr_crypt(struct blkcipher_desc *desc,
struct des3_ede_x86_ctx *ctx = crypto_blkcipher_ctx(desc->tfm);
unsigned int bsize = DES3_EDE_BLOCK_SIZE;
unsigned int nbytes = walk->nbytes;
- u64 *src = (u64 *)walk->src.virt.addr;
- u64 *dst = (u64 *)walk->dst.virt.addr;
+ __be64 *src = (__be64 *)walk->src.virt.addr;
+ __be64 *dst = (__be64 *)walk->dst.virt.addr;
u64 ctrblk = be64_to_cpu(*(__be64 *)walk->iv);
__be64 ctrblocks[3];

2014-06-25 13:50:45

by Herbert Xu

Subject: Re: [PATCH] crypto: des3_ede/x86-64: fix parse warning

On Mon, Jun 23, 2014 at 07:39:17PM +0300, Jussi Kivilinna wrote:
> Patch fixes following sparse warning:
>
> CHECK arch/x86/crypto/des3_ede_glue.c
> arch/x86/crypto/des3_ede_glue.c:308:52: warning: restricted __be64 degrades to integer
> arch/x86/crypto/des3_ede_glue.c:309:52: warning: restricted __be64 degrades to integer
> arch/x86/crypto/des3_ede_glue.c:310:52: warning: restricted __be64 degrades to integer
> arch/x86/crypto/des3_ede_glue.c:326:44: warning: restricted __be64 degrades to integer
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Jussi Kivilinna <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt