2017-04-19 13:26:31

by Cabiddu, Giovanni

Subject: [PATCH] crypto: acomp - report scomp implementations

Fix crypto_has_acomp to report scomp implementations.

Signed-off-by: Giovanni Cabiddu <[email protected]>
---
include/crypto/acompress.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
index e328b52..39871f9 100644
--- a/include/crypto/acompress.h
+++ b/include/crypto/acompress.h
@@ -162,6 +162,7 @@ static inline int crypto_has_acomp(const char *alg_name, u32 type, u32 mask)
{
type &= ~CRYPTO_ALG_TYPE_MASK;
type |= CRYPTO_ALG_TYPE_ACOMPRESS;
+ type |= CRYPTO_ALG_TYPE_SCOMPRESS;
mask |= CRYPTO_ALG_TYPE_MASK;

return crypto_has_alg(alg_name, type, mask);
--
2.9.3

2017-04-21 11:39:41

by Herbert Xu

Subject: Re: [PATCH] crypto: acomp - report scomp implementations

On Wed, Apr 19, 2017 at 02:26:14PM +0100, Giovanni Cabiddu wrote:
> Fix crypto_has_acomp to report scomp implementations.
>
> Signed-off-by: Giovanni Cabiddu <[email protected]>
> ---
> include/crypto/acompress.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
> index e328b52..39871f9 100644
> --- a/include/crypto/acompress.h
> +++ b/include/crypto/acompress.h
> @@ -162,6 +162,7 @@ static inline int crypto_has_acomp(const char *alg_name, u32 type, u32 mask)
> {
> type &= ~CRYPTO_ALG_TYPE_MASK;
> type |= CRYPTO_ALG_TYPE_ACOMPRESS;
> + type |= CRYPTO_ALG_TYPE_SCOMPRESS;
> mask |= CRYPTO_ALG_TYPE_MASK;
>
> return crypto_has_alg(alg_name, type, mask);

Are you sure this works? I think you should modify the mask instead.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt