2019-04-23 16:29:59

by Vitaly Chikunov

Subject: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

Fix undefined symbol issue in ecrdsa_generic module when ASN1
or OID_REGISTRY aren't enabled in the config by selecting these
options for CRYPTO_ECRDSA.

ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!

Reported-by: Randy Dunlap <[email protected]>
Cc: Stephen Rothwell <[email protected]>
Signed-off-by: Vitaly Chikunov <[email protected]>
---
crypto/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git crypto/Kconfig crypto/Kconfig
index 4446833f6eca..3d056e7da65f 100644
--- crypto/Kconfig
+++ crypto/Kconfig
@@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
select CRYPTO_ECC
select CRYPTO_AKCIPHER
select CRYPTO_STREEBOG
+ select OID_REGISTRY
+ select ASN1
help
Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
--
2.11.0

2019-04-23 20:20:34

by Randy Dunlap

Subject: Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

On 4/23/19 9:29 AM, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
>
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
>
> Reported-by: Randy Dunlap <[email protected]>
> Cc: Stephen Rothwell <[email protected]>
> Signed-off-by: Vitaly Chikunov <[email protected]>

Acked-by: Randy Dunlap <[email protected]> # build-tested

Thanks.

My tools would prefer to see the diff at one tree level higher:


> ---
> crypto/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git crypto/Kconfig crypto/Kconfig

diff --git a/crypto/Kconfig b/crypto/Kconfig

for any spelling of a and b.


> index 4446833f6eca..3d056e7da65f 100644
> --- crypto/Kconfig
> +++ crypto/Kconfig

--- a/crypto/Kconfig
+++ b/crypto/Kconfig

> @@ -264,6 +264,8 @@ config CRYPTO_ECRDSA
> select CRYPTO_ECC
> select CRYPTO_AKCIPHER
> select CRYPTO_STREEBOG
> + select OID_REGISTRY
> + select ASN1
> help
> Elliptic Curve Russian Digital Signature Algorithm (GOST R 34.10-2012,
> RFC 7091, ISO/IEC 14888-3:2018) is one of the Russian cryptographic
>


--
~Randy

2019-04-25 08:46:08

by Herbert Xu

Subject: Re: [PATCH] crypto: ecrdsa - select ASN1 and OID_REGISTRY for EC-RDSA

On Tue, Apr 23, 2019 at 07:29:54PM +0300, Vitaly Chikunov wrote:
> Fix undefined symbol issue in ecrdsa_generic module when ASN1
> or OID_REGISTRY aren't enabled in the config by selecting these
> options for CRYPTO_ECRDSA.
>
> ERROR: "asn1_ber_decoder" [crypto/ecrdsa_generic.ko] undefined!
> ERROR: "look_up_OID" [crypto/ecrdsa_generic.ko] undefined!
>
> Reported-by: Randy Dunlap <[email protected]>
> Cc: Stephen Rothwell <[email protected]>
> Signed-off-by: Vitaly Chikunov <[email protected]>
> ---
> crypto/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt