2019-07-18 13:17:59

by Chuhong Yuan

Subject: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc

Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
memory and then zeroing it with memset 0.
This simplifies the code.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/crypto/ccp/ccp-ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 866b2e05ca77..03797c42b336 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -150,14 +150,13 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
if (len <= CCP_DMAPOOL_MAX_SIZE) {
wa->dma_pool = cmd_q->dma_pool;

- wa->address = dma_pool_alloc(wa->dma_pool, GFP_KERNEL,
+ wa->address = dma_pool_zalloc(wa->dma_pool, GFP_KERNEL,
&wa->dma.address);
if (!wa->address)
return -ENOMEM;

wa->dma.length = CCP_DMAPOOL_MAX_SIZE;

- memset(wa->address, 0, CCP_DMAPOOL_MAX_SIZE);
} else {
wa->address = kzalloc(len, GFP_KERNEL);
if (!wa->address)
--
2.20.1

2019-07-18 21:51:08

by Gary R Hook

Subject: Re: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc

On 7/18/19 8:16 AM, Chuhong Yuan wrote:
> Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
> memory and then zeroing it with memset 0.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Acked-by: Gary R Hook <[email protected]>

> ---
> drivers/crypto/ccp/ccp-ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index 866b2e05ca77..03797c42b336 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -150,14 +150,13 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
> if (len <= CCP_DMAPOOL_MAX_SIZE) {
> wa->dma_pool = cmd_q->dma_pool;
>
> - wa->address = dma_pool_alloc(wa->dma_pool, GFP_KERNEL,
> + wa->address = dma_pool_zalloc(wa->dma_pool, GFP_KERNEL,
> &wa->dma.address);
> if (!wa->address)
> return -ENOMEM;
>
> wa->dma.length = CCP_DMAPOOL_MAX_SIZE;
>
> - memset(wa->address, 0, CCP_DMAPOOL_MAX_SIZE);
> } else {
> wa->address = kzalloc(len, GFP_KERNEL);
> if (!wa->address)
>

2019-07-26 12:36:08

by Herbert Xu

Subject: Re: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc

Chuhong Yuan <[email protected]> wrote:
> Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
> memory and then zeroing it with memset 0.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan <[email protected]>
> ---
> drivers/crypto/ccp/ccp-ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt