2020-01-14 12:30:47

by Vinay Kumar Yadav

[permalink] [raw]
Subject: [PATCH 0/3] Crypto/chtls bug fixes

These patches fix followings
patch 1: Corrected function call context
patch 2: TCP listen fail bug fix
patch 3: Added stats counter for tls

Vinay Kumar Yadav (3):
Crypto/chtls: Corrected function call context
crypto/chtls: Fixed listen fail when max stid range reached
chelsio/cxgb4: Added tls stats prints

drivers/crypto/chelsio/chtls/chtls_cm.c | 30 +++++++++----------
drivers/crypto/chelsio/chtls/chtls_main.c | 5 ++--
.../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 7 +++++
3 files changed, 24 insertions(+), 18 deletions(-)

--
2.24.1


2020-01-14 12:31:27

by Vinay Kumar Yadav

[permalink] [raw]
Subject: [PATCH 2/3] crypto/chtls: Fixed listen fail when max stid range reached

Do not return error when max stid reached, to Fallback to nic mode.

Signed-off-by: Vinay Kumar Yadav <[email protected]>
---
drivers/crypto/chelsio/chtls/chtls_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c
index a148f5c6621b..a038de90b2ea 100644
--- a/drivers/crypto/chelsio/chtls/chtls_main.c
+++ b/drivers/crypto/chelsio/chtls/chtls_main.c
@@ -84,7 +84,6 @@ static int listen_backlog_rcv(struct sock *sk, struct sk_buff *skb)
static int chtls_start_listen(struct chtls_dev *cdev, struct sock *sk)
{
struct chtls_listen *clisten;
- int err;

if (sk->sk_protocol != IPPROTO_TCP)
return -EPROTONOSUPPORT;
@@ -100,10 +99,10 @@ static int chtls_start_listen(struct chtls_dev *cdev, struct sock *sk)
clisten->cdev = cdev;
clisten->sk = sk;
mutex_lock(&notify_mutex);
- err = raw_notifier_call_chain(&listen_notify_list,
+ raw_notifier_call_chain(&listen_notify_list,
CHTLS_LISTEN_START, clisten);
mutex_unlock(&notify_mutex);
- return err;
+ return 0;
}

static void chtls_stop_listen(struct chtls_dev *cdev, struct sock *sk)
--
2.24.1

2020-01-14 12:31:37

by Vinay Kumar Yadav

[permalink] [raw]
Subject: [PATCH 3/3] chelsio/cxgb4: Added tls stats prints

Signed-off-by: Vinay Kumar Yadav <[email protected]>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
index 93868dca186a..c41b72c879c1 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c
@@ -3399,6 +3399,13 @@ static int chcr_stats_show(struct seq_file *seq, void *v)
atomic_read(&adap->chcr_stats.fallback));
seq_printf(seq, "IPSec PDU: %10u\n",
atomic_read(&adap->chcr_stats.ipsec_cnt));
+ seq_printf(seq, "TLS PDU Tx: %10u\n",
+ atomic_read(&adap->chcr_stats.tls_pdu_tx));
+ seq_printf(seq, "TLS PDU Rx: %10u\n",
+ atomic_read(&adap->chcr_stats.tls_pdu_rx));
+ seq_printf(seq, "TLS Keys (DDR) Count: %10u\n",
+ atomic_read(&adap->chcr_stats.tls_key));
+
return 0;
}
DEFINE_SHOW_ATTRIBUTE(chcr_stats);
--
2.24.1

2020-01-22 10:13:09

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 0/3] Crypto/chtls bug fixes

On Tue, Jan 14, 2020 at 05:58:46PM +0530, Vinay Kumar Yadav wrote:
> These patches fix followings
> patch 1: Corrected function call context
> patch 2: TCP listen fail bug fix
> patch 3: Added stats counter for tls
>
> Vinay Kumar Yadav (3):
> Crypto/chtls: Corrected function call context
> crypto/chtls: Fixed listen fail when max stid range reached
> chelsio/cxgb4: Added tls stats prints
>
> drivers/crypto/chelsio/chtls/chtls_cm.c | 30 +++++++++----------
> drivers/crypto/chelsio/chtls/chtls_main.c | 5 ++--
> .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 7 +++++
> 3 files changed, 24 insertions(+), 18 deletions(-)

Patches 1-2 applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt