2020-04-03 19:51:15

by Corentin LABBE

Subject: [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header

This patch add __crypto_rng_cast() to the rng header like other
__algo_cast functions.

Signed-off-by: Corentin Labbe <[email protected]>
---
include/crypto/rng.h | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/include/crypto/rng.h b/include/crypto/rng.h
index 8b4b844b4eef..0e140f132efe 100644
--- a/include/crypto/rng.h
+++ b/include/crypto/rng.h
@@ -198,4 +198,9 @@ static inline int crypto_rng_seedsize(struct crypto_rng *tfm)
return crypto_rng_alg(tfm)->seedsize;
}

+static inline struct crypto_rng *__crypto_rng_cast(struct crypto_tfm *tfm)
+{
+ return container_of(tfm, struct crypto_rng, base);
+}
+
#endif
--
2.24.1

2020-04-16 06:07:37

by Herbert Xu

Subject: Re: [PATCH 1/7] crypto: rng - add missing __crypto_rng_cast to the rng header

On Fri, Apr 03, 2020 at 07:50:32PM +0000, Corentin Labbe wrote:
> This patch add __crypto_rng_cast() to the rng header like other
> __algo_cast functions.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> include/crypto/rng.h | 5 +++++
> 1 file changed, 5 insertions(+)

This should never be exported. Either change the driver to use
use crypto_tfm_ctx instead of crypto_rng_ctx, or if you have the
time please convert the rng API over to the new way of doing things
like aead/skcipher.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt