2020-04-03 22:07:15

by Tang Bin

Subject: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()

When something goes wrong, platform_get_irq() will print an error message,
so in order to avoid the situation of repeat output，we should remove
dev_err here.

Signed-off-by: Tang Bin <[email protected]>
---
Changes from v5
- modify the commit message.

Changes from v4:
- rewrite the code, because the code in v4 is wrong, sorry.

Changes form v3:
- fix the theme writing error.

Changes from v2:
- modify the theme format and content description.
- reformat the patch, it's the wrong way to resubmit a new patch that
should be modified on top of the original. The original piece is:
https://lore.kernel.org/patchwork/patch/1219611/

Changes from v1:
- the title has changed, because the description is not very detailed.
- the code has been modified, because it needs to match the theme.

drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 9d4ead2f7..411857fad 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -253,10 +253,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
mc->irqs = devm_kcalloc(mc->dev, MAXFLOW, sizeof(int), GFP_KERNEL);
for (i = 0; i < MAXFLOW; i++) {
mc->irqs[i] = platform_get_irq(pdev, i);
- if (mc->irqs[i] < 0) {
- dev_err(mc->dev, "Cannot get IRQ for flow %d\n", i);
+ if (mc->irqs[i] < 0)
return mc->irqs[i];
- }

err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
--
2.20.1.windows.1

2020-04-16 06:52:54

by Herbert Xu

Subject: Re: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe()

On Sat, Apr 04, 2020 at 06:07:54AM +0800, Tang Bin wrote:
> When something goes wrong, platform_get_irq() will print an error message,
> so in order to avoid the situation of repeat output，we should remove
> dev_err here.
>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> Changes from v5
> - modify the commit message.
>
> Changes from v4:
> - rewrite the code, because the code in v4 is wrong, sorry.
>
> Changes form v3:
> - fix the theme writing error.
>
> Changes from v2:
> - modify the theme format and content description.
> - reformat the patch, it's the wrong way to resubmit a new patch that
> should be modified on top of the original. The original piece is:
> https://lore.kernel.org/patchwork/patch/1219611/
>
> Changes from v1:
> - the title has changed, because the description is not very detailed.
> - the code has been modified, because it needs to match the theme.
>
> drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt