Subject: [PATCH v2] crypto: acomp - search acomp with scomp backend in crypto_has_acomp

users may call crypto_has_acomp to confirm the existence of acomp before using
crypto_acomp APIs. Right now, many acomp have scomp backend, for example, lz4,
lzo, deflate etc. crypto_has_acomp will return false for them even though they
support acomp APIs.

Signed-off-by: Barry Song <[email protected]>
---
-v2: fixed the mask according to herbert's feedback

include/crypto/acompress.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/crypto/acompress.h b/include/crypto/acompress.h
index d873f999b334..2b4d2b06ccbd 100644
--- a/include/crypto/acompress.h
+++ b/include/crypto/acompress.h
@@ -157,7 +157,7 @@ static inline int crypto_has_acomp(const char *alg_name, u32 type, u32 mask)
{
type &= ~CRYPTO_ALG_TYPE_MASK;
type |= CRYPTO_ALG_TYPE_ACOMPRESS;
- mask |= CRYPTO_ALG_TYPE_MASK;
+ mask |= CRYPTO_ALG_TYPE_ACOMPRESS_MASK;

return crypto_has_alg(alg_name, type, mask);
}
--
2.23.0



2020-05-08 06:06:05

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v2] crypto: acomp - search acomp with scomp backend in crypto_has_acomp

On Thu, Apr 30, 2020 at 05:10:18PM +1200, Barry Song wrote:
> users may call crypto_has_acomp to confirm the existence of acomp before using
> crypto_acomp APIs. Right now, many acomp have scomp backend, for example, lz4,
> lzo, deflate etc. crypto_has_acomp will return false for them even though they
> support acomp APIs.
>
> Signed-off-by: Barry Song <[email protected]>
> ---
> -v2: fixed the mask according to herbert's feedback
>
> include/crypto/acompress.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt