2020-04-22 12:59:13

by Andy Shevchenko

Subject: [PATCH v1] hwrng: Use UUID API for exporting the UUID

There is export_uuid() function which exports uuid_t to the u8 array.
Use it instead of open coding variant.

This allows to hide the uuid_t internals.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/char/hw_random/optee-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
index ddfbabaa5f8f6..49b2e02537ddb 100644
--- a/drivers/char/hw_random/optee-rng.c
+++ b/drivers/char/hw_random/optee-rng.c
@@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)
return -ENODEV;

/* Open session with hwrng Trusted App */
- memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
+ export_uuid(sess_arg.uuid, &rng_device->id.uuid);
sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
sess_arg.num_params = 0;

--
2.26.1

2020-04-23 05:21:30

by Sumit Garg

Subject: Re: [PATCH v1] hwrng: Use UUID API for exporting the UUID

On Wed, 22 Apr 2020 at 18:28, Andy Shevchenko
<[email protected]> wrote:
>
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/char/hw_random/optee-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Sumit Garg <[email protected]>

> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index ddfbabaa5f8f6..49b2e02537ddb 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)
> return -ENODEV;
>
> /* Open session with hwrng Trusted App */
> - memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> + export_uuid(sess_arg.uuid, &rng_device->id.uuid);
> sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
> sess_arg.num_params = 0;
>
> --
> 2.26.1
>

2020-04-30 05:32:24

by Herbert Xu

Subject: Re: [PATCH v1] hwrng: Use UUID API for exporting the UUID

On Wed, Apr 22, 2020 at 03:58:08PM +0300, Andy Shevchenko wrote:
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/char/hw_random/optee-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt