2020-10-16 09:09:17

by Zhang Qilong

Subject: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device

pm_runtime_get_sync() will increment pm usage counter even
when it returns an error code. We should call put operation
in error handling paths of omap_aes_hw_init.

Signed-off-by: Zhang Qilong <[email protected]>
---
drivers/crypto/omap-aes.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 4fd14d90cc40..70ea5784a024 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -105,6 +105,7 @@ static int omap_aes_hw_init(struct omap_aes_dev *dd)

err = pm_runtime_get_sync(dd->dev);
if (err < 0) {
+ pm_runtime_put_noidle(dd->dev);
dev_err(dd->dev, "failed to get sync: %d\n", err);
return err;
}
--
2.17.1

2020-10-30 06:52:03

by Herbert Xu

Subject: Re: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device

On Fri, Oct 16, 2020 at 05:05:36PM +0800, Zhang Qilong wrote:
> pm_runtime_get_sync() will increment pm usage counter even
> when it returns an error code. We should call put operation
> in error handling paths of omap_aes_hw_init.
>
> Signed-off-by: Zhang Qilong <[email protected]>
> ---
> drivers/crypto/omap-aes.c | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt