2021-03-10 10:17:28

by Ard Biesheuvel

[permalink] [raw]
Subject: [PATCH v3 0/2] crypto: arm - clean up redundant helper macros

Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get
rid of the locally defined ones that live in the ChaCha and AES crypto code.

Changes since v2:
- fix rev_32->rev_l in the patch subject lines
- add Eric's ack

Changes since v1:
- drop the patch that introduces rev_l, it has been merged in v5.12-rc
- rev_32 was renamed to rev_l, so both patches were updated to reflect that
- add acks from Nico, Geert and Linus

Cc: Geert Uytterhoeven <[email protected]>
Cc: Nicolas Pitre <[email protected]>
Cc: Eric Biggers <[email protected]>
Cc: Linus Walleij <[email protected]>

Ard Biesheuvel (2):
crypto: arm/aes-scalar - switch to common rev_l/mov_l macros
crypto: arm/chacha-scalar - switch to common rev_l macro

arch/arm/crypto/aes-cipher-core.S | 42 +++++--------------
arch/arm/crypto/chacha-scalar-core.S | 43 ++++++--------------
2 files changed, 23 insertions(+), 62 deletions(-)

--
2.30.1


2021-03-19 11:06:08

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] crypto: arm - clean up redundant helper macros

On Wed, Mar 10, 2021 at 11:14:19AM +0100, Ard Biesheuvel wrote:
> Now that ARM's asm/assembler.h provides mov_l and rev_l macros, let's get
> rid of the locally defined ones that live in the ChaCha and AES crypto code.
>
> Changes since v2:
> - fix rev_32->rev_l in the patch subject lines
> - add Eric's ack
>
> Changes since v1:
> - drop the patch that introduces rev_l, it has been merged in v5.12-rc
> - rev_32 was renamed to rev_l, so both patches were updated to reflect that
> - add acks from Nico, Geert and Linus
>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: Nicolas Pitre <[email protected]>
> Cc: Eric Biggers <[email protected]>
> Cc: Linus Walleij <[email protected]>
>
> Ard Biesheuvel (2):
> crypto: arm/aes-scalar - switch to common rev_l/mov_l macros
> crypto: arm/chacha-scalar - switch to common rev_l macro
>
> arch/arm/crypto/aes-cipher-core.S | 42 +++++--------------
> arch/arm/crypto/chacha-scalar-core.S | 43 ++++++--------------
> 2 files changed, 23 insertions(+), 62 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt