2021-03-31 03:37:37

by Jiapeng Chong

Subject: [PATCH] crypto: deflate - Remove useless call "zlib_inflateEnd"

Fix the following whitescan warning:

Calling "zlib_inflateEnd(&ctx->decomp_stream)" is only useful for its
return value, which is ignored.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
crypto/deflate.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/crypto/deflate.c b/crypto/deflate.c
index b2a46f6..cac1672 100644
--- a/crypto/deflate.c
+++ b/crypto/deflate.c
@@ -101,7 +101,6 @@ static void deflate_comp_exit(struct deflate_ctx *ctx)

static void deflate_decomp_exit(struct deflate_ctx *ctx)
{
- zlib_inflateEnd(&ctx->decomp_stream);
vfree(ctx->decomp_stream.workspace);
}

--
1.8.3.1

2021-04-09 07:20:57

by Herbert Xu

Subject: Re: [PATCH] crypto: deflate - Remove useless call "zlib_inflateEnd"

On Wed, Mar 31, 2021 at 11:34:57AM +0800, Jiapeng Chong wrote:
> Fix the following whitescan warning:
>
> Calling "zlib_inflateEnd(&ctx->decomp_stream)" is only useful for its
> return value, which is ignored.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> crypto/deflate.c | 1 -
> 1 file changed, 1 deletion(-)

The function might not do anything today but the documentation
clearly indicates that it could free any dynamically allocated
data so it should stay.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt