2021-04-01 07:33:55

by Zhiqi Song

Subject: [PATCH] crypto: cbc - fix coding style

Fixed following checkpatch error:
- do not use assignment in if condition

Signed-off-by: Zhiqi Song <[email protected]>
---
crypto/cbc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/crypto/cbc.c b/crypto/cbc.c
index 6c03e96..152d48d 100644
--- a/crypto/cbc.c
+++ b/crypto/cbc.c
@@ -140,7 +140,8 @@ static int crypto_cbc_decrypt_inplace(struct skcipher_walk *walk,

for (;;) {
fn(tfm, src, src);
- if ((nbytes -= bsize) < bsize)
+ nbytes -= bsize;
+ if (nbytes < bsize)
break;
crypto_xor(src, src - bsize, bsize);
src -= bsize;
--
2.7.4

2021-04-09 07:28:47

by Herbert Xu

Subject: Re: [PATCH] crypto: cbc - fix coding style

On Thu, Apr 01, 2021 at 03:31:41PM +0800, Zhiqi Song wrote:
> Fixed following checkpatch error:
> - do not use assignment in if condition
>
> Signed-off-by: Zhiqi Song <[email protected]>
> ---
> crypto/cbc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

This patch does not appear to improve the code.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt