2021-04-02 11:25:37

by yekai (A)

Subject: [PATCH v2] crypto: hisilicon/qm - delete redundant code

The "qdma" is a structure variable instead of actual data. This
structure doesn't need to be zerod, The memset is useless and redundant.
So delete it.

Signed-off-by: Kai Ye <[email protected]>
---
Changes v1 -> v2:
Re-edit the description.

drivers/crypto/hisilicon/qm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 13cb421..88a6c6f 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -2527,7 +2527,6 @@ void hisi_qm_uninit(struct hisi_qm *qm)
hisi_qm_cache_wb(qm);
dma_free_coherent(dev, qm->qdma.size,
qm->qdma.va, qm->qdma.dma);
- memset(&qm->qdma, 0, sizeof(qm->qdma));
}

qm_irq_unregister(qm);
--
2.8.1

2021-04-09 07:56:17

by Herbert Xu

Subject: Re: [PATCH v2] crypto: hisilicon/qm - delete redundant code

On Fri, Apr 02, 2021 at 07:22:30PM +0800, Kai Ye wrote:
> The "qdma" is a structure variable instead of actual data. This
> structure doesn't need to be zerod, The memset is useless and redundant.
> So delete it.
>
> Signed-off-by: Kai Ye <[email protected]>
> ---
> Changes v1 -> v2:
> Re-edit the description.
>
> drivers/crypto/hisilicon/qm.c | 1 -
> 1 file changed, 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt