2021-04-15 10:09:08

by Vinay Kumar Yadav

Subject: [PATCH] chelsio/chcr: Remove useless MODULE_VERSION

kernel version describes module state more accurately.
hence remove chcr versioning.

Signed-off-by: Vinay Kumar Yadav <[email protected]>
---
drivers/crypto/chelsio/chcr_core.c | 3 +--
drivers/crypto/chelsio/chcr_core.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/crypto/chelsio/chcr_core.c b/drivers/crypto/chelsio/chcr_core.c
index f91f9d762a45..12fdae41a967 100644
--- a/drivers/crypto/chelsio/chcr_core.c
+++ b/drivers/crypto/chelsio/chcr_core.c
@@ -184,7 +184,7 @@ static void *chcr_uld_add(const struct cxgb4_lld_info *lld)
struct uld_ctx *u_ctx;

/* Create the device and add it in the device list */
- pr_info_once("%s - version %s\n", DRV_DESC, DRV_VERSION);
+ pr_info_once("%s\n", DRV_DESC);
if (!(lld->ulp_crypto & ULP_CRYPTO_LOOKASIDE))
return ERR_PTR(-EOPNOTSUPP);

@@ -309,4 +309,3 @@ module_exit(chcr_crypto_exit);
MODULE_DESCRIPTION("Crypto Co-processor for Chelsio Terminator cards.");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Chelsio Communications");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/crypto/chelsio/chcr_core.h b/drivers/crypto/chelsio/chcr_core.h
index b02f981e7c32..f7c8bb95a71b 100644
--- a/drivers/crypto/chelsio/chcr_core.h
+++ b/drivers/crypto/chelsio/chcr_core.h
@@ -44,7 +44,6 @@
#include "cxgb4_uld.h"

#define DRV_MODULE_NAME "chcr"
-#define DRV_VERSION "1.0.0.0-ko"
#define DRV_DESC "Chelsio T6 Crypto Co-processor Driver"

#define MAX_PENDING_REQ_TO_HW 20
--
2.30.2

2021-04-22 07:47:30

by Herbert Xu

Subject: Re: [PATCH] chelsio/chcr: Remove useless MODULE_VERSION

On Thu, Apr 15, 2021 at 03:36:07PM +0530, Vinay Kumar Yadav wrote:
> kernel version describes module state more accurately.
> hence remove chcr versioning.
>
> Signed-off-by: Vinay Kumar Yadav <[email protected]>
> ---
> drivers/crypto/chelsio/chcr_core.c | 3 +--
> drivers/crypto/chelsio/chcr_core.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt