2021-05-05 18:29:48

by Łukasz Stelmach

Subject: [PATCH v3] hwrng: exynos - Fix runtime PM imbalance on error

pm_runtime_resume_and_get() wraps around pm_runtime_get_sync() and
decrements the runtime PM usage counter in case the latter function
fails and keeps the counter balanced.

Signed-off-by: Łukasz Stelmach <[email protected]>
---
Changes in v3:
- use pm_runtime_resume_and_get()

Changes in v2:
- removed Change-Id from the commit message

drivers/char/hw_random/exynos-trng.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/hw_random/exynos-trng.c b/drivers/char/hw_random/exynos-trng.c
index 8e1fe3f8dd2d..c8db62bc5ff7 100644
--- a/drivers/char/hw_random/exynos-trng.c
+++ b/drivers/char/hw_random/exynos-trng.c
@@ -132,7 +132,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
return PTR_ERR(trng->mem);

pm_runtime_enable(&pdev->dev);
- ret = pm_runtime_get_sync(&pdev->dev);
+ ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret < 0) {
dev_err(&pdev->dev, "Could not get runtime PM.\n");
goto err_pm_get;
@@ -165,7 +165,7 @@ static int exynos_trng_probe(struct platform_device *pdev)
clk_disable_unprepare(trng->clk);

err_clock:
- pm_runtime_put_sync(&pdev->dev);
+ pm_runtime_put_noidle(&pdev->dev);

err_pm_get:
pm_runtime_disable(&pdev->dev);
--
2.26.2

2021-05-05 21:04:54

by Krzysztof Kozlowski

Subject: Re: [PATCH v3] hwrng: exynos - Fix runtime PM imbalance on error

On 05/05/2021 14:29, Łukasz Stelmach wrote:
> pm_runtime_resume_and_get() wraps around pm_runtime_get_sync() and
> decrements the runtime PM usage counter in case the latter function
> fails and keeps the counter balanced.
>
> Signed-off-by: Łukasz Stelmach <[email protected]>
> ---
> Changes in v3:
> - use pm_runtime_resume_and_get()
>
> Changes in v2:
> - removed Change-Id from the commit message
>
> drivers/char/hw_random/exynos-trng.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2021-05-14 11:36:47

by Herbert Xu

Subject: Re: [PATCH v3] hwrng: exynos - Fix runtime PM imbalance on error

On Wed, May 05, 2021 at 08:29:14PM +0200, Łukasz Stelmach wrote:
> pm_runtime_resume_and_get() wraps around pm_runtime_get_sync() and
> decrements the runtime PM usage counter in case the latter function
> fails and keeps the counter balanced.
>
> Signed-off-by: Łukasz Stelmach <[email protected]>
> ---
> Changes in v3:
> - use pm_runtime_resume_and_get()
>
> Changes in v2:
> - removed Change-Id from the commit message
>
> drivers/char/hw_random/exynos-trng.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt