Hi Linus:
This push fixes the following issues:
- Regression in af_alg that affects iwd.
- Restore polling delay in qat.
- Double free in ingenic on error path.
- Potential build failure in sa2ul due to missing Kconfig dependency.
The following changes since commit 9123e3a74ec7b934a4a099e98af6a61c2f80bbf5:
Linux 5.9-rc1 (2020-08-16 13:04:57 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to c195d66a8a75c60515819b101975f38b7ec6577f:
crypto: af_alg - Work around empty control messages without MSG_MORE (2020-08-27 23:20:36 +1000)
----------------------------------------------------------------
Giovanni Cabiddu (1):
crypto: qat - add delay before polling mailbox
Herbert Xu (1):
crypto: af_alg - Work around empty control messages without MSG_MORE
Randy Dunlap (1):
crypto: sa2ul - add Kconfig selects to fix build error
Wei Yongjun (1):
crypto: ingenic - Drop kfree for memory allocated with devm_kzalloc
crypto/af_alg.c | 13 ++++++++++---
drivers/char/hw_random/ingenic-rng.c | 9 ++-------
drivers/crypto/Kconfig | 3 +++
drivers/crypto/qat/qat_common/adf_admin.c | 7 ++++---
4 files changed, 19 insertions(+), 13 deletions(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Mon, 31 Aug 2020 08:33:04 +1000:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e43327c706f28d9e66fc4242af4aefdd69e8ff24
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
The pull request you sent on Thu, 10 Sep 2020 10:34:23 +1000:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7fe10096c1508c7f033d34d0741809f8eecc1ed4
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push fixes a regression in x86/poly1305.
The following changes since commit 3093e7c16e12d729c325adb3c53dde7308cefbd8:
X.509: Fix modular build of public_key_sm2 (2020-10-08 16:39:14 +1100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to c3a98c3ad5c0dc60a1ac66bf91147a3f39cac96b:
crypto: x86/poly1305 - add back a needed assignment (2020-10-24 09:38:32 +1100)
----------------------------------------------------------------
Eric Biggers (1):
crypto: x86/poly1305 - add back a needed assignment
arch/x86/crypto/poly1305_glue.c | 1 +
1 file changed, 1 insertion(+)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Mon, 26 Oct 2020 12:11:59 +1100:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/41ba50b0572e90ed3d24fe4def54567e9050bc47
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push fixes a number of autobuild failures due to missing
Kconfig dependencies.
The following changes since commit 93cebeb1c21a65b92636aaa278a32fbc0415ec67:
crypto: qat - add capability detection logic in qat_4xxx (2020-12-11 21:54:16 +1100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to c0e583ab2016de8dedfb73934d4c4e8ff5bd896c:
crypto: qat - add CRYPTO_AES to Kconfig dependencies (2020-12-23 18:45:23 +1100)
----------------------------------------------------------------
Daniele Alessandrelli (1):
crypto: keembay - Add dependency on HAS_IOMEM
Geert Uytterhoeven (1):
crypto: keembay - CRYPTO_DEV_KEEMBAY_OCS_AES_SM4 should depend on ARCH_KEEMBAY
Marco Chiappero (1):
crypto: qat - add CRYPTO_AES to Kconfig dependencies
drivers/crypto/keembay/Kconfig | 5 +++--
drivers/crypto/qat/Kconfig | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Linus:
This push fixes a functional bug in arm/chacha-neon as well as a
potential buffer overflow in ecdh.
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e:
Linux 5.11-rc1 (2020-12-27 15:30:22 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 0aa171e9b267ce7c52d3a3df7bc9c1fc0203dec5:
crypto: ecdh - avoid buffer overflow in ecdh_set_secret() (2021-01-03 08:35:35 +1100)
----------------------------------------------------------------
Ard Biesheuvel (2):
crypto: arm/chacha-neon - add missing counter increment
crypto: ecdh - avoid buffer overflow in ecdh_set_secret()
arch/arm/crypto/chacha-glue.c | 1 +
crypto/ecdh.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Linus:
This push fixes a Kconfig dependency issue with omap-sham and a
divide by zero in xor on some platforms.
The following changes since commit 0aa171e9b267ce7c52d3a3df7bc9c1fc0203dec5:
crypto: ecdh - avoid buffer overflow in ecdh_set_secret() (2021-01-03 08:35:35 +1100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 382811940303f7cd01d0f3dcdf432dfd89c5a98e:
crypto: omap-sham - Fix link error without crypto-engine (2021-01-08 15:37:55 +1100)
----------------------------------------------------------------
Arnd Bergmann (1):
crypto: omap-sham - Fix link error without crypto-engine
Kirill Tkhai (1):
crypto: xor - Fix divide error in do_xor_speed()
crypto/xor.c | 2 ++
drivers/crypto/Kconfig | 1 +
2 files changed, 3 insertions(+)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Mon, 18 Jan 2021 16:13:13 +1100:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/fd3958eac387593d02e4d4287658ba04bcdb235a
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push contains the following fixes and changes:
- Regression in drbg due to missing self-test for new default algorithm.
- Add ratelimit on user-triggerable message in qat.
- Build failure due to missing dependency in sl3516.
- Remove obsolete PageSlab checks.
- Bogus hardware register writes on Kunpeng920 in hisilicon/sec.
The following changes since commit 9f38b678ffc4e2ccf167a1131c0403dc4f5e1bb7:
crypto: sl3516 - depends on HAS_IOMEM (2021-06-24 14:57:28 +0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 66192b2e3fd8ab97ed518d6c0240e26655a20b4b:
crypto: hisilicon/sec - fix the process of disabling sva prefetching (2021-06-28 11:28:09 +0800)
----------------------------------------------------------------
Colin Ian King (1):
crypto: qat - ratelimit invalid ioctl message and print the invalid cmd
Geert Uytterhoeven (2):
crypto: sl3516 - Typo s/Stormlink/Storlink/
crypto: sl3516 - Add dependency on ARCH_GEMINI
Herbert Xu (2):
crypto: scatterwalk - Remove obsolete PageSlab check
crypto: omap - Drop obsolete PageSlab check
Kai Ye (1):
crypto: hisilicon/sec - fix the process of disabling sva prefetching
Stephan M?ller (1):
crypto: drbg - self test for HMAC(SHA-512)
crypto/testmgr.c | 5 ++-
crypto/testmgr.h | 49 +++++++++++++++++++++++++++++
drivers/crypto/Kconfig | 6 ++--
drivers/crypto/gemini/sl3516-ce-cipher.c | 2 +-
drivers/crypto/gemini/sl3516-ce-core.c | 2 +-
drivers/crypto/hisilicon/sec2/sec_main.c | 3 ++
drivers/crypto/omap-crypto.c | 3 +-
drivers/crypto/qat/qat_common/adf_ctl_drv.c | 2 +-
include/crypto/scatterwalk.h | 7 +----
9 files changed, 64 insertions(+), 15 deletions(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Thu, 8 Jul 2021 11:09:13 +0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/d8dc121eeab9abfbc510097f8db83e87560f753b
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push contains a fix for a potential boot failure due to
a missing Kconfig dependency for people upgrading with the DRBG
enabled.
The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:
Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 5261cdf457ce3635bf18d393a3c1991dcfaf9d02:
crypto: drbg - select SHA512 (2021-07-16 15:49:31 +0800)
----------------------------------------------------------------
Stephan Mueller (1):
crypto: drbg - select SHA512
crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Tue, 17 Aug 2021 09:36:01 +0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/794c7931a2428a656551f2179e6a093233a6e0aa
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push contains fixes for a resource leak in ccp as well as
stack corruption in x86/sm4.
The following changes since commit 6880fa6c56601bb8ed59df6c30fd390cc5f6dd8f:
Linux 5.15-rc1 (2021-09-12 16:28:37 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 0e14ef38669ce4faa80589247fe8ed8a3780f414:
crypto: x86/sm4 - Fix frame pointer stack corruption (2021-09-24 15:58:50 +0800)
----------------------------------------------------------------
Dan Carpenter (1):
crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()
Josh Poimboeuf (1):
crypto: x86/sm4 - Fix frame pointer stack corruption
arch/x86/crypto/sm4-aesni-avx-asm_64.S | 5 +++--
drivers/crypto/ccp/ccp-ops.c | 14 ++++++++------
2 files changed, 11 insertions(+), 8 deletions(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Wed, 29 Sep 2021 10:38:43 +0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6e439bbd436e39f15abc9587cdd23d56257780cb
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push fixes a build-time warning in x86/sm4.
The following changes since commit 0e14ef38669ce4faa80589247fe8ed8a3780f414:
crypto: x86/sm4 - Fix frame pointer stack corruption (2021-09-24 15:58:50 +0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to f8690a4b5a1b64f74ae5c4f7c4ea880d8a8e1a0d:
crypto: x86/sm4 - Fix invalid section entry size (2021-10-22 20:23:01 +0800)
----------------------------------------------------------------
Tianjia Zhang (1):
crypto: x86/sm4 - Fix invalid section entry size
arch/x86/crypto/sm4-aesni-avx-asm_64.S | 6 +++++-
arch/x86/crypto/sm4-aesni-avx2-asm_64.S | 6 +++++-
2 files changed, 10 insertions(+), 2 deletions(-)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Oct 28, 2021 at 9:14 PM Herbert Xu <[email protected]> wrote:
>
> This push fixes a build-time warning in x86/sm4.
Hmm..
> Tianjia Zhang (1):
> crypto: x86/sm4 - Fix invalid section entry size
So I do wonder why the crypto code asm tends to use such complex
".section" directives.
Almost everythign else in the kernel just uses
.section <name>,"a"
for data (and "ax" for text).
The crypto code uses that very subtle "M" flag which allows the linker
to merge data, but how much of a win is that added complexity? Now you
need to get the sizes exactly right, and you hit tooling issues.
Plus, I get the feeling that some people have just copied-and-pasted
those things, and don't necessarily realize just _how_ subtle 'M'
sections are.
How much of a data savings is it to have this complexity? Particularly
since I suspect most of the time these things end up being individual
modules, and never actually get linked together at all?
So I get this very strong feeling that the crypto code is doing
complicated and fragile things that cause tooling issues - and does so
for no good reason and no actual real-life upside.
I've pulled this, but I do suspect that all the fancy
.section .rodata.xyz, "aM", @progbits, abc
could just as well be
.section .rodata, "a"
instead, and you guys are only causing problems for yourself by trying
to be clever in pointless ways.
Linus
The pull request you sent on Fri, 29 Oct 2021 12:14:09 +0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/75c7a6c1ca63131875fe869cbfd404c94d0e1944
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
On Fri, Oct 29, 2021 at 10:39:35AM -0700, Linus Torvalds wrote:
>
> Plus, I get the feeling that some people have just copied-and-pasted
> those things, and don't necessarily realize just _how_ subtle 'M'
> sections are.
>
> How much of a data savings is it to have this complexity? Particularly
> since I suspect most of the time these things end up being individual
> modules, and never actually get linked together at all?
Let me copy Denys Vlasenko who introduced this.
But you're absolutely right that the recent additions are
more likely to be just cut-n-paste rather than deeply thought
through.
FWIW the original change that added this was:
ommit e183914af00e15eb41ae666d44e323bfa154be13
Author: Denys Vlasenko <[email protected]>
Date: Thu Jan 19 22:33:04 2017 +0100
crypto: x86 - make constants readonly, allow linker to merge them
A lot of asm-optimized routines in arch/x86/crypto/ keep its
constants in .data. This is wrong, they should be on .rodata.
Mnay of these constants are the same in different modules.
For example, 128-bit shuffle mask 0x000102030405060708090A0B0C0D0E0F
exists in at least half a dozen places.
There is a way to let linker merge them and use just one copy.
The rules are as follows: mergeable objects of different sizes
should not share sections. You can't put them all in one .rodata
section, they will lose "mergeability".
GCC puts its mergeable constants in ".rodata.cstSIZE" sections,
or ".rodata.cstSIZE.<object_name>" if -fdata-sections is used.
This patch does the same:
.section .rodata.cst16.SHUF_MASK, "aM", @progbits, 16
It is important that all data in such section consists of
16-byte elements, not larger ones, and there are no implicit
use of one element from another.
When this is not the case, use non-mergeable section:
.section .rodata[.VAR_NAME], "a", @progbits
This reduces .data by ~15 kbytes:
text data bss dec hex filename
11097415 2705840 2630712 16433967 fac32f vmlinux-prev.o
11112095 2690672 2630712 16433479 fac147 vmlinux.o
Merged objects are visible in System.map:
ffffffff81a28810 r POLY
ffffffff81a28810 r POLY
ffffffff81a28820 r TWOONE
ffffffff81a28820 r TWOONE
ffffffff81a28830 r PSHUFFLE_BYTE_FLIP_MASK <- merged regardless of
ffffffff81a28830 r SHUF_MASK <------------- the name difference
ffffffff81a28830 r SHUF_MASK
ffffffff81a28830 r SHUF_MASK
..
ffffffff81a28d00 r K512 <- merged three identical 640-byte tables
ffffffff81a28d00 r K512
ffffffff81a28d00 r K512
Use of object names in section name suffixes is not strictly necessary,
but might help if someday link stage will use garbage collection
to eliminate unused sections (ld --gc-sections).
Signed-off-by: Denys Vlasenko <[email protected]>
CC: Herbert Xu <[email protected]>
CC: Josh Poimboeuf <[email protected]>
CC: Xiaodong Liu <[email protected]>
CC: Megha Dey <[email protected]>
CC: [email protected]
CC: [email protected]
CC: [email protected]
Signed-off-by: Herbert Xu <[email protected]>
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Hi Linus:
This push fixes a boot crash regression.
The following changes since commit 39ef08517082a424b5b65c3dbaa6c0fa9d3303b9:
crypto: testmgr - fix wrong key length for pkcs1pad (2021-10-29 21:04:04 +0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to beaaaa37c664e9afdf2913aee19185d8e3793b50:
crypto: api - Fix boot-up crash when crypto manager is disabled (2021-11-09 13:45:48 +0800)
----------------------------------------------------------------
Herbert Xu (1):
crypto: api - Fix boot-up crash when crypto manager is disabled
crypto/algapi.c | 2 ++
1 file changed, 2 insertions(+)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Fri, 12 Nov 2021 18:48:15 +0800:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/66f4beaa6c1d28161f534471484b2daa2de1dce0
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
Hi Linus:
This push fixes a regression in the qat driver.
The following changes since commit fa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf:
Linux 5.16-rc1 (2021-11-14 13:56:52 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
for you to fetch changes up to 27750a315aba7e6675bb1c3dfd4481c4f6888af1:
crypto: qat - do not handle PFVF sources for qat_4xxx (2021-12-17 13:11:54 +1100)
----------------------------------------------------------------
Giovanni Cabiddu (1):
crypto: qat - do not handle PFVF sources for qat_4xxx
drivers/crypto/qat/qat_4xxx/adf_4xxx_hw_data.c | 7 +++++++
1 file changed, 7 insertions(+)
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The pull request you sent on Wed, 22 Dec 2021 16:13:07 +1100:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/e19e226345196649e83d49c6997e806a8ecdafe6
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html