2021-07-16 07:50:05

by Herbert Xu

Subject: Re: [PATCH v2 2/4] crypto: arm64/sm4-ce - Make dependent on sm4 library instead of sm4-generic

On Thu, Jun 24, 2021 at 04:08:55PM +0800, Tianjia Zhang wrote:
>
> +int sm4_ce_setkey(struct crypto_tfm *tfm, const u8 *in_key,
> + unsigned int key_len)
> +{
> + struct sm4_ctx *ctx = crypto_tfm_ctx(tfm);
> +
> + return sm4_expandkey(ctx, in_key, key_len);
> +}

This triggers a new warning. Please fix and resubmit.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2021-07-16 09:33:07

by Tianjia Zhang

Subject: Re: [PATCH v2 2/4] crypto: arm64/sm4-ce - Make dependent on sm4 library instead of sm4-generic

Hi Herbert,

On 7/16/21 3:48 PM, Herbert Xu wrote:
> On Thu, Jun 24, 2021 at 04:08:55PM +0800, Tianjia Zhang wrote:
>>
>> +int sm4_ce_setkey(struct crypto_tfm *tfm, const u8 *in_key,
>> + unsigned int key_len)
>> +{
>> + struct sm4_ctx *ctx = crypto_tfm_ctx(tfm);
>> +
>> + return sm4_expandkey(ctx, in_key, key_len);
>> +}
>
> This triggers a new warning. Please fix and resubmit.
>
> Thanks,
>

Thanks for your comment, I will fix and resubmit in next version patch.

Cheers,
Tianjia