2021-12-07 18:58:14

by Colin Ian King

Subject: [PATCH] crypto: x86/des: remove redundant assignment of variable nbytes

The variable nbytes is being assigned a value that is never read, it is
being re-assigned in the following statement. The assignment is redundant
and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
arch/x86/crypto/des3_ede_glue.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede_glue.c
index e7cb68a3db3b..787c234d2469 100644
--- a/arch/x86/crypto/des3_ede_glue.c
+++ b/arch/x86/crypto/des3_ede_glue.c
@@ -164,7 +164,7 @@ static int cbc_encrypt(struct skcipher_request *req)

err = skcipher_walk_virt(&walk, req, false);

- while ((nbytes = walk.nbytes)) {
+ while (walk.nbytes) {
nbytes = __cbc_encrypt(ctx, &walk);
err = skcipher_walk_done(&walk, nbytes);
}
@@ -243,7 +243,7 @@ static int cbc_decrypt(struct skcipher_request *req)

err = skcipher_walk_virt(&walk, req, false);

- while ((nbytes = walk.nbytes)) {
+ while (walk.nbytes) {
nbytes = __cbc_decrypt(ctx, &walk);
err = skcipher_walk_done(&walk, nbytes);
}
--
2.33.1

2021-12-17 08:38:57

by Herbert Xu

Subject: Re: [PATCH] crypto: x86/des: remove redundant assignment of variable nbytes

On Tue, Dec 07, 2021 at 06:58:09PM +0000, Colin Ian King wrote:
> The variable nbytes is being assigned a value that is never read, it is
> being re-assigned in the following statement. The assignment is redundant
> and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> arch/x86/crypto/des3_ede_glue.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt