2023-01-19 01:35:41

by Yang Yingliang

Subject: [PATCH -next] crypto: aspeed: change aspeed_acry_akcipher_algs to static

aspeed_acry_akcipher_algs is only used in aspeed-acry.c now,
change it to static.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/crypto/aspeed/aspeed-acry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c
index 6d3790583f8b..164c524015f0 100644
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -603,7 +603,7 @@ static void aspeed_acry_rsa_exit_tfm(struct crypto_akcipher *tfm)
crypto_free_akcipher(ctx->fallback_tfm);
}

-struct aspeed_acry_alg aspeed_acry_akcipher_algs[] = {
+static struct aspeed_acry_alg aspeed_acry_akcipher_algs[] = {
{
.akcipher = {
.encrypt = aspeed_acry_rsa_enc,
--
2.25.1

2023-01-19 04:55:28

by Andrew Jeffery

Subject: Re: [PATCH -next] crypto: aspeed: change aspeed_acry_akcipher_algs to static

On Thu, 19 Jan 2023, at 12:18, Yang Yingliang wrote:
> aspeed_acry_akcipher_algs is only used in aspeed-acry.c now,
> change it to static.

Acked-by: Andrew Jeffery <[email protected]>

2023-01-19 05:42:24

by Neal Liu

Subject: RE: [PATCH -next] crypto: aspeed: change aspeed_acry_akcipher_algs to static

> aspeed_acry_akcipher_algs is only used in aspeed-acry.c now, change it to
> static.
>
> Signed-off-by: Yang Yingliang <[email protected]>

Reviewed-by: Neal Liu <[email protected]>

> ---
> drivers/crypto/aspeed/aspeed-acry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/aspeed/aspeed-acry.c
> b/drivers/crypto/aspeed/aspeed-acry.c
> index 6d3790583f8b..164c524015f0 100644
> --- a/drivers/crypto/aspeed/aspeed-acry.c
> +++ b/drivers/crypto/aspeed/aspeed-acry.c
> @@ -603,7 +603,7 @@ static void aspeed_acry_rsa_exit_tfm(struct
> crypto_akcipher *tfm)
> crypto_free_akcipher(ctx->fallback_tfm);
> }
>
> -struct aspeed_acry_alg aspeed_acry_akcipher_algs[] = {
> +static struct aspeed_acry_alg aspeed_acry_akcipher_algs[] = {
> {
> .akcipher = {
> .encrypt = aspeed_acry_rsa_enc,
> --
> 2.25.1

2023-01-27 11:07:54

by Herbert Xu

Subject: Re: [PATCH -next] crypto: aspeed: change aspeed_acry_akcipher_algs to static

On Thu, Jan 19, 2023 at 09:48:59AM +0800, Yang Yingliang wrote:
> aspeed_acry_akcipher_algs is only used in aspeed-acry.c now,
> change it to static.
>
> Signed-off-by: Yang Yingliang <[email protected]>
> ---
> drivers/crypto/aspeed/aspeed-acry.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt