2023-04-28 21:12:02

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator stats

Hi--

On 4/28/23 13:55, Tom Zanussi wrote:
> diff --git a/drivers/crypto/intel/iaa/Kconfig b/drivers/crypto/intel/iaa/Kconfig
> index fcccb6ff7e29..cffb3a4359fc 100644
> --- a/drivers/crypto/intel/iaa/Kconfig
> +++ b/drivers/crypto/intel/iaa/Kconfig
> @@ -8,3 +8,12 @@ config CRYPTO_DEV_IAA_CRYPTO
> decompression with the Intel Analytics Accelerator (IAA)
> hardware using the cryptographic API. If you choose 'M'
> here, the module will be called iaa_crypto.
> +
> +config CRYPTO_DEV_IAA_CRYPTO_STATS
> + bool "Enable Intel(R) IAA Compression Accelerator Statistics"
> + depends on CRYPTO_DEV_IAA_CRYPTO
> + default n
> + help
> + Enable statistics for the IAA compression accelerator.

The line above should use one tab + 2 spaces for indentation
instead of bunch-of-spaces.

> + These include per-device and per-workqueue statistics in
> + addition to global driver statistics.

Thanks.
--
~Randy


2023-04-28 21:18:27

by Tom Zanussi

[permalink] [raw]
Subject: Re: [PATCH v3 15/15] crypto: iaa - Add IAA Compression Accelerator stats

Hi Randy,

On Fri, 2023-04-28 at 14:00 -0700, Randy Dunlap wrote:
> Hi--
>
> On 4/28/23 13:55, Tom Zanussi wrote:
> > diff --git a/drivers/crypto/intel/iaa/Kconfig
> > b/drivers/crypto/intel/iaa/Kconfig
> > index fcccb6ff7e29..cffb3a4359fc 100644
> > --- a/drivers/crypto/intel/iaa/Kconfig
> > +++ b/drivers/crypto/intel/iaa/Kconfig
> > @@ -8,3 +8,12 @@ config CRYPTO_DEV_IAA_CRYPTO
> >           decompression with the Intel Analytics Accelerator (IAA)
> >           hardware using the cryptographic API.  If you choose 'M'
> >           here, the module will be called iaa_crypto.
> > +
> > +config CRYPTO_DEV_IAA_CRYPTO_STATS
> > +       bool "Enable Intel(R) IAA Compression Accelerator
> > Statistics"
> > +       depends on CRYPTO_DEV_IAA_CRYPTO
> > +       default n
> > +       help
> > +          Enable statistics for the IAA compression accelerator.
>
> The line above should use one tab + 2 spaces for indentation
> instead of bunch-of-spaces.

Yep, so much for consistency, will fix. Thanks for pointing it out.

Tom

>
> > +         These include per-device and per-workqueue statistics in
> > +         addition to global driver statistics.
>
> Thanks.