2022-01-22 00:49:42

by Shijith Thotton

Subject: [PATCH] crypto: octeontx2: select CONFIG_NET_DEVLINK

OcteonTX2 CPT driver will fail to link without devlink support.

aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_egrp_delete':
otx2_cpt_devlink.c:18: undefined reference to `devlink_priv'
aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_egrp_create':
otx2_cpt_devlink.c:9: undefined reference to `devlink_priv'
aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_uc_info':
otx2_cpt_devlink.c:27: undefined reference to `devlink_priv'

Fixes: fed8f4d5f946 ("crypto: octeontx2 - parameters for custom engine groups")

Signed-off-by: Shijith Thotton <[email protected]>
---
drivers/crypto/marvell/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/marvell/Kconfig b/drivers/crypto/marvell/Kconfig
index 9125199f1702..a48591af12d0 100644
--- a/drivers/crypto/marvell/Kconfig
+++ b/drivers/crypto/marvell/Kconfig
@@ -47,6 +47,7 @@ config CRYPTO_DEV_OCTEONTX2_CPT
select CRYPTO_SKCIPHER
select CRYPTO_HASH
select CRYPTO_AEAD
+ select NET_DEVLINK
help
This driver allows you to utilize the Marvell Cryptographic
Accelerator Unit(CPT) found in OcteonTX2 series of processors.
--
2.25.1

2022-01-29 22:03:44

by Herbert Xu

Subject: Re: [PATCH] crypto: octeontx2: select CONFIG_NET_DEVLINK

Shijith Thotton <[email protected]> wrote:
> OcteonTX2 CPT driver will fail to link without devlink support.
>
> aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_egrp_delete':
> otx2_cpt_devlink.c:18: undefined reference to `devlink_priv'
> aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_egrp_create':
> otx2_cpt_devlink.c:9: undefined reference to `devlink_priv'
> aarch64-linux-gnu-ld: otx2_cpt_devlink.o: in function `otx2_cpt_dl_uc_info':
> otx2_cpt_devlink.c:27: undefined reference to `devlink_priv'
>
> Fixes: fed8f4d5f946 ("crypto: octeontx2 - parameters for custom engine groups")
>
> Signed-off-by: Shijith Thotton <[email protected]>
> ---
> drivers/crypto/marvell/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt