2010-03-16 14:49:35

by Uri Simchoni

Subject: [PATCH 1/10] crypto mv_cesa : Invoke the user callback from a softirq context

Invoke the user callback from a softirq context

Signed-off-by: Uri Simchoni <[email protected]>
---
diff -upr linux-2.6.32.8_orig/drivers/crypto/mv_cesa.c
linux-2.6.32.8_p1/drivers/crypto/mv_cesa.c
--- linux-2.6.32.8_orig/drivers/crypto/mv_cesa.c 2010-02-09
14:57:19.000000000 +0200
+++ linux-2.6.32.8_p1/drivers/crypto/mv_cesa.c 2010-03-16
08:59:12.074583163 +0200
@@ -275,7 +275,9 @@ static void dequeue_complete_req(void)
sg_miter_stop(&cpg->p.dst_sg_it);
mv_crypto_algo_completion();
cpg->eng_st = ENGINE_IDLE;
+ local_bh_disable();
req->base.complete(&req->base, 0);
+ local_bh_enable();
}
}

2010-03-19 06:04:52

by Herbert Xu

Subject: Re: [PATCH 1/10] crypto mv_cesa : Invoke the user callback from a softirq context

On Tue, Mar 16, 2010 at 04:42:39PM +0200, Uri Simchoni wrote:
> Invoke the user callback from a softirq context
>
> Signed-off-by: Uri Simchoni <[email protected]>
> ---
> diff -upr linux-2.6.32.8_orig/drivers/crypto/mv_cesa.c
> linux-2.6.32.8_p1/drivers/crypto/mv_cesa.c
> --- linux-2.6.32.8_orig/drivers/crypto/mv_cesa.c 2010-02-09
> 14:57:19.000000000 +0200
> +++ linux-2.6.32.8_p1/drivers/crypto/mv_cesa.c 2010-03-16
> 08:59:12.074583163 +0200
> @@ -275,7 +275,9 @@ static void dequeue_complete_req(void)
> sg_miter_stop(&cpg->p.dst_sg_it);
> mv_crypto_algo_completion();
> cpg->eng_st = ENGINE_IDLE;
> + local_bh_disable();
> req->base.complete(&req->base, 0);
> + local_bh_enable();
> }
> }

Your patches are all space damaged and cannot be applied until
that is fixed.

Please always check your patches by trying to apply the copy
you receive via the list. If that doesn't work, then you need
to figure out why.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt