On 11/22/2011 08:44 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20111122:
(first seen in linux-next of Nov. 22)
modular build:
ERROR: "cryptd_free_ablkcipher" [arch/x86/crypto/serpent-sse2-i586.ko] undefined!
ERROR: "cryptd_ablkcipher_child" [arch/x86/crypto/serpent-sse2-i586.ko] undefined!
ERROR: "cryptd_alloc_ablkcipher" [arch/x86/crypto/serpent-sse2-i586.ko] undefined!
or builtin:
serpent_sse2_glue.c:(.text+0x3e054): undefined reference to `cryptd_alloc_ablkcipher'
serpent_sse2_glue.c:(.text+0x3e0b0): undefined reference to `cryptd_alloc_ablkcipher'
serpent_sse2_glue.c:(.text+0x3e10c): undefined reference to `cryptd_alloc_ablkcipher'
serpent_sse2_glue.c:(.text+0x3e168): undefined reference to `cryptd_alloc_ablkcipher'
serpent_sse2_glue.c:(.text+0x3e5c9): undefined reference to `cryptd_ablkcipher_child'
serpent_sse2_glue.c:(.text+0x3e602): undefined reference to `cryptd_free_ablkcipher'
serpent_sse2_glue.c:(.text+0x3e65f): undefined reference to `cryptd_ablkcipher_child'
randconfig for the modular build case is attached.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and
CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD.
Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Jussi Kivilinna <[email protected]>
---
crypto/Kconfig | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 16e0c13..b8d1b10 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -770,6 +770,7 @@ config CRYPTO_SERPENT_SSE2_X86_64
tristate "Serpent cipher algorithm (x86_64/SSE2)"
depends on X86 && 64BIT
select CRYPTO_ALGAPI
+ select CRYPTO_CRYPTD
select CRYPTO_SERPENT
help
Serpent cipher algorithm, by Anderson, Biham & Knudsen.
@@ -787,6 +788,7 @@ config CRYPTO_SERPENT_SSE2_586
tristate "Serpent cipher algorithm (i586/SSE2)"
depends on X86 && !64BIT
select CRYPTO_ALGAPI
+ select CRYPTO_CRYPTD
select CRYPTO_SERPENT
help
Serpent cipher algorithm, by Anderson, Biham & Knudsen.
On 11/23/2011 10:37 PM, Jussi Kivilinna wrote:
> Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and
> CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD.
>
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Jussi Kivilinna <[email protected]>
Acked-by: Randy Dunlap <[email protected]>
Thanks.
> ---
> crypto/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 16e0c13..b8d1b10 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -770,6 +770,7 @@ config CRYPTO_SERPENT_SSE2_X86_64
> tristate "Serpent cipher algorithm (x86_64/SSE2)"
> depends on X86 && 64BIT
> select CRYPTO_ALGAPI
> + select CRYPTO_CRYPTD
> select CRYPTO_SERPENT
> help
> Serpent cipher algorithm, by Anderson, Biham & Knudsen.
> @@ -787,6 +788,7 @@ config CRYPTO_SERPENT_SSE2_586
> tristate "Serpent cipher algorithm (i586/SSE2)"
> depends on X86 && !64BIT
> select CRYPTO_ALGAPI
> + select CRYPTO_CRYPTD
> select CRYPTO_SERPENT
> help
> Serpent cipher algorithm, by Anderson, Biham & Knudsen.
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
On Thu, Nov 24, 2011 at 10:35:29AM -0800, Randy Dunlap wrote:
> On 11/23/2011 10:37 PM, Jussi Kivilinna wrote:
> > Since serpent_sse2_glue.c uses cryptd, CRYPTO_SERPENT_SSE2_X86_64 and
> > CRYPTO_SERPENT_SSE2_586 should be selecting CRYPTO_CRYPTD.
> >
> > Reported-by: Randy Dunlap <[email protected]>
> > Signed-off-by: Jussi Kivilinna <[email protected]>
>
> Acked-by: Randy Dunlap <[email protected]>
Patch applied. Thanks
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt