2012-08-29 20:37:28

by Jussi Kivilinna

[permalink] [raw]
Subject: [PATCH] crypto: 842 - remove .cra_list initialization

.cra_list initialization is unneeded and have been removed from all other
crypto modules except 842.

Cc: Robert Jennings <[email protected]>
Cc: Seth Jennings <[email protected]>
Signed-off-by: Jussi Kivilinna <[email protected]>

---

I don't have ppc64 cross-compiler set up, so I couldn't test this. However
patch is obvious and should work.
---
crypto/842.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/crypto/842.c b/crypto/842.c
index 144767d..65c7a89c 100644
--- a/crypto/842.c
+++ b/crypto/842.c
@@ -157,7 +157,6 @@ static struct crypto_alg alg = {
.cra_flags = CRYPTO_ALG_TYPE_COMPRESS,
.cra_ctxsize = sizeof(struct nx842_ctx),
.cra_module = THIS_MODULE,
- .cra_list = LIST_HEAD_INIT(alg.cra_list),
.cra_init = nx842_init,
.cra_exit = nx842_exit,
.cra_u = { .compress = {


2012-08-29 22:13:01

by Seth Jennings

[permalink] [raw]
Subject: Re: [PATCH] crypto: 842 - remove .cra_list initialization

On 08/29/2012 03:37 PM, Jussi Kivilinna wrote:
> .cra_list initialization is unneeded and have been removed from all other
> crypto modules except 842.
>
> Cc: Robert Jennings <[email protected]>
> Cc: Seth Jennings <[email protected]>
> Signed-off-by: Jussi Kivilinna <[email protected]>
>
> ---
>
> I don't have ppc64 cross-compiler set up, so I couldn't test this. However
> patch is obvious and should work.

Applied on top of next-20120824 and it builds on ppc64, just
for peace of mind :)

I see the other patch in next that did this for all the others.

Acked-by: Seth Jennings <[email protected]>

--
Seth

2012-09-06 20:22:46

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: 842 - remove .cra_list initialization

On Wed, Aug 29, 2012 at 11:37:25PM +0300, Jussi Kivilinna wrote:
> .cra_list initialization is unneeded and have been removed from all other
> crypto modules except 842.
>
> Cc: Robert Jennings <[email protected]>
> Cc: Seth Jennings <[email protected]>
> Signed-off-by: Jussi Kivilinna <[email protected]>

Patch applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt