2021-05-19 20:09:49

by Bhupesh Sharma

Subject: [PATCH v3 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()

QCE crypto driver is right now too silent even if the probe() is ok
and a valid crypto IP version is found.

Convert the dev_dbg() message to a dev_info() instead.

Cc: Thara Gopinath <[email protected]>
Cc: Bjorn Andersson <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Andy Gross <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: Michael Turquette <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Bhupesh Sharma <[email protected]>
---
drivers/crypto/qce/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
index aecb2cdd79e5..8b3e2b4580c2 100644
--- a/drivers/crypto/qce/core.c
+++ b/drivers/crypto/qce/core.c
@@ -179,7 +179,7 @@ static int qce_check_version(struct qce_device *qce)
*/
qce->pipe_pair_id = qce->dma.rxchan->chan_id >> 1;

- dev_dbg(qce->dev, "Crypto device found, version %d.%d.%d\n",
+ dev_info(qce->dev, "Crypto device found, version %d.%d.%d\n",
major, minor, step);

return 0;
--
2.31.1

2021-05-21 09:09:40

by Thara Gopinath

Subject: Re: [PATCH v3 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info()

On 5/19/21 10:36 AM, Bhupesh Sharma wrote:
> QCE crypto driver is right now too silent even if the probe() is ok
> and a valid crypto IP version is found.
>
> Convert the dev_dbg() message to a dev_info() instead.
>
> Cc: Thara Gopinath <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: Andy Gross <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Cc: Michael Turquette <[email protected]>
> Cc: Vinod Koul <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Bhupesh Sharma <[email protected]>

Reviewed-by: Thara Gopinath <[email protected]>

Warm Regards
Thara
> ---
> drivers/crypto/qce/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c
> index aecb2cdd79e5..8b3e2b4580c2 100644
> --- a/drivers/crypto/qce/core.c
> +++ b/drivers/crypto/qce/core.c
> @@ -179,7 +179,7 @@ static int qce_check_version(struct qce_device *qce)
> */
> qce->pipe_pair_id = qce->dma.rxchan->chan_id >> 1;
>
> - dev_dbg(qce->dev, "Crypto device found, version %d.%d.%d\n",
> + dev_info(qce->dev, "Crypto device found, version %d.%d.%d\n",
> major, minor, step);
>
> return 0;
>