The .S_shipped yields a .S, and the pattern in these directories is to
add that to .gitignore so that git-status doesn't raise a fuss.
Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
Reported-by: Emil Renner Berthing <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Signed-off-by: Jason A. Donenfeld <[email protected]>
---
arch/arm/crypto/.gitignore | 1 +
arch/arm64/crypto/.gitignore | 1 +
2 files changed, 2 insertions(+)
diff --git a/arch/arm/crypto/.gitignore b/arch/arm/crypto/.gitignore
index 31e1f538df7d..a3c7ad52a469 100644
--- a/arch/arm/crypto/.gitignore
+++ b/arch/arm/crypto/.gitignore
@@ -1,3 +1,4 @@
aesbs-core.S
sha256-core.S
sha512-core.S
+poly1305-core.S
diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
index 879df8781ed5..e403b1343328 100644
--- a/arch/arm64/crypto/.gitignore
+++ b/arch/arm64/crypto/.gitignore
@@ -1,2 +1,3 @@
sha256-core.S
sha512-core.S
+poly1305-core.S
--
2.25.1
I think this might have slipped through the cracks?
On Wed, Mar 25, 2020 at 10:32:41PM -0600, Jason A. Donenfeld wrote:
> I think this might have slipped through the cracks?
It's on the list:
https://patchwork.kernel.org/project/linux-crypto/list/
Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Mar 25, 2020 at 10:39 PM Herbert Xu <[email protected]> wrote:
>
> On Wed, Mar 25, 2020 at 10:32:41PM -0600, Jason A. Donenfeld wrote:
> > I think this might have slipped through the cracks?
>
> It's on the list:
>
> https://patchwork.kernel.org/project/linux-crypto/list/
Oooo! Had no idea you used Patchwork. Thanks! Will bookmark that and
check there periodically instead.
Jason
On Thu, Mar 19, 2020 at 12:01:14PM -0600, Jason A. Donenfeld wrote:
> The .S_shipped yields a .S, and the pattern in these directories is to
> add that to .gitignore so that git-status doesn't raise a fuss.
>
> Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> Reported-by: Emil Renner Berthing <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Signed-off-by: Jason A. Donenfeld <[email protected]>
> ---
> arch/arm/crypto/.gitignore | 1 +
> arch/arm64/crypto/.gitignore | 1 +
> 2 files changed, 2 insertions(+)
Patch applied.
> diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
> index 879df8781ed5..e403b1343328 100644
> --- a/arch/arm64/crypto/.gitignore
> +++ b/arch/arm64/crypto/.gitignore
> @@ -1,2 +1,3 @@
> sha256-core.S
> sha512-core.S
> +poly1305-core.S
This didn't apply because a similar patch had already been added
to cryptodev a month ago. Please base your patches on the latest
cryptodev in future.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Mar 26, 2020 at 10:55 PM Herbert Xu <[email protected]> wrote:
>
> On Thu, Mar 19, 2020 at 12:01:14PM -0600, Jason A. Donenfeld wrote:
> > The .S_shipped yields a .S, and the pattern in these directories is to
> > add that to .gitignore so that git-status doesn't raise a fuss.
> >
> > Fixes: a6b803b3ddc7 ("crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Fixes: f569ca164751 ("crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation")
> > Reported-by: Emil Renner Berthing <[email protected]>
> > Cc: Ard Biesheuvel <[email protected]>
> > Signed-off-by: Jason A. Donenfeld <[email protected]>
> > ---
> > arch/arm/crypto/.gitignore | 1 +
> > arch/arm64/crypto/.gitignore | 1 +
> > 2 files changed, 2 insertions(+)
>
> Patch applied.
>
> > diff --git a/arch/arm64/crypto/.gitignore b/arch/arm64/crypto/.gitignore
> > index 879df8781ed5..e403b1343328 100644
> > --- a/arch/arm64/crypto/.gitignore
> > +++ b/arch/arm64/crypto/.gitignore
> > @@ -1,2 +1,3 @@
> > sha256-core.S
> > sha512-core.S
> > +poly1305-core.S
>
> This didn't apply because a similar patch had already been added
> to cryptodev a month ago. Please base your patches on the latest
> cryptodev in future.
I had sent this with [PATCH crypto] in the subject line, meant for
crypto-2.6.git for 5.6, since it's a bug fix for the things there. I
didn't realize you were queuing these changes for 5.7 instead.
On Thu, Mar 26, 2020 at 10:57:50PM -0600, Jason A. Donenfeld wrote:
>
> I had sent this with [PATCH crypto] in the subject line, meant for
> crypto-2.6.git for 5.6, since it's a bug fix for the things there. I
> didn't realize you were queuing these changes for 5.7 instead.
Sorry about that. However, as a general rule I don't take trivial
fixes such as these for the crypto tree.
Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt