2014-04-11 09:28:07

by Sonic Zhang

Subject: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

From: Sonic Zhang <[email protected]>

in case of multiple crc devices are probed.
Call platform_set_drvdata() before adding new CRC device into the list.

Signed-off-by: Sonic Zhang <[email protected]>
---
v3-change:
- check list_is_singular() before register the algorithm

drivers/crypto/bfin_crc.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c
index cea3e8c..892b6d2 100644
--- a/drivers/crypto/bfin_crc.c
+++ b/drivers/crypto/bfin_crc.c
@@ -665,19 +665,19 @@ static int bfin_crypto_crc_probe(struct platform_device *pdev)
if (timeout == 0)
dev_info(&pdev->dev, "init crc poly timeout\n");

+ platform_set_drvdata(pdev, crc);
+
spin_lock(&crc_list.lock);
list_add(&crc->list, &crc_list.dev_list);
spin_unlock(&crc_list.lock);

- platform_set_drvdata(pdev, crc);
-
- ret = crypto_register_ahash(&algs);
- if (ret) {
- spin_lock(&crc_list.lock);
- list_del(&crc->list);
- spin_unlock(&crc_list.lock);
- dev_err(&pdev->dev, "Cann't register crypto ahash device\n");
- goto out_error_dma;
+ if (list_is_singular(&crc_list.dev_list)) {
+ ret = crypto_register_ahash(&algs);
+ if (ret) {
+ dev_err(&pdev->dev,
+ "Cann't register crypto ahash device\n");
+ goto out_error_dma;
+ }
}

dev_info(&pdev->dev, "initialized\n");
--
1.8.2.3

2014-04-11 09:33:37

by Marek Vasut

Subject: Re: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote:
> From: Sonic Zhang <[email protected]>
>
> in case of multiple crc devices are probed.
> Call platform_set_drvdata() before adding new CRC device into the list.
>
> Signed-off-by: Sonic Zhang <[email protected]>
> ---
> v3-change:
> - check list_is_singular() before register the algorithm
>
> drivers/crypto/bfin_crc.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c
> index cea3e8c..892b6d2 100644
> --- a/drivers/crypto/bfin_crc.c
> +++ b/drivers/crypto/bfin_crc.c
> @@ -665,19 +665,19 @@ static int bfin_crypto_crc_probe(struct
> platform_device *pdev) if (timeout == 0)
> dev_info(&pdev->dev, "init crc poly timeout\n");
>
> + platform_set_drvdata(pdev, crc);
> +
> spin_lock(&crc_list.lock);
> list_add(&crc->list, &crc_list.dev_list);
> spin_unlock(&crc_list.lock);
>
> - platform_set_drvdata(pdev, crc);
> -
> - ret = crypto_register_ahash(&algs);
> - if (ret) {
> - spin_lock(&crc_list.lock);
> - list_del(&crc->list);
> - spin_unlock(&crc_list.lock);
> - dev_err(&pdev->dev, "Cann't register crypto ahash device\n");
> - goto out_error_dma;
> + if (list_is_singular(&crc_list.dev_list)) {
> + ret = crypto_register_ahash(&algs);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "Cann't register crypto ahash device\n");

"Cann't" with two Ns ;-/

Well, add "Reviewed-by: Marek Vasut <[email protected]>" into the next go please :)

Best regards,
Marek Vasut

2014-04-14 04:23:11

by Sonic Zhang

Subject: Re: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

Hi Herbert,

Could you please review this patch?

Thanks

Sonic Zhang

On Fri, Apr 11, 2014 at 5:33 PM, Marek Vasut <[email protected]> wrote:
> On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote:
>> From: Sonic Zhang <[email protected]>
>>
>> in case of multiple crc devices are probed.
>> Call platform_set_drvdata() before adding new CRC device into the list.
>>
>> Signed-off-by: Sonic Zhang <[email protected]>
>> ---
>> v3-change:
>> - check list_is_singular() before register the algorithm
>>
>> drivers/crypto/bfin_crc.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c
>> index cea3e8c..892b6d2 100644
>> --- a/drivers/crypto/bfin_crc.c
>> +++ b/drivers/crypto/bfin_crc.c
>> @@ -665,19 +665,19 @@ static int bfin_crypto_crc_probe(struct
>> platform_device *pdev) if (timeout == 0)
>> dev_info(&pdev->dev, "init crc poly timeout\n");
>>
>> + platform_set_drvdata(pdev, crc);
>> +
>> spin_lock(&crc_list.lock);
>> list_add(&crc->list, &crc_list.dev_list);
>> spin_unlock(&crc_list.lock);
>>
>> - platform_set_drvdata(pdev, crc);
>> -
>> - ret = crypto_register_ahash(&algs);
>> - if (ret) {
>> - spin_lock(&crc_list.lock);
>> - list_del(&crc->list);
>> - spin_unlock(&crc_list.lock);
>> - dev_err(&pdev->dev, "Cann't register crypto ahash device\n");
>> - goto out_error_dma;
>> + if (list_is_singular(&crc_list.dev_list)) {
>> + ret = crypto_register_ahash(&algs);
>> + if (ret) {
>> + dev_err(&pdev->dev,
>> + "Cann't register crypto ahash device\n");
>
> "Cann't" with two Ns ;-/
>
> Well, add "Reviewed-by: Marek Vasut <[email protected]>" into the next go please :)
>
> Best regards,
> Marek Vasut

2014-04-16 13:49:36

by Herbert Xu

Subject: Re: [PATCH v3 1/2] crypto: bfin_crc: ignore duplicated registration of the same algorithm

On Fri, Apr 11, 2014 at 11:33:37AM +0200, Marek Vasut wrote:
> On Friday, April 11, 2014 at 11:30:25 AM, Sonic Zhang wrote:
> > From: Sonic Zhang <[email protected]>
> >
> > in case of multiple crc devices are probed.
> > Call platform_set_drvdata() before adding new CRC device into the list.
> >
> > Signed-off-by: Sonic Zhang <[email protected]>
> > ---
> > v3-change:
> > - check list_is_singular() before register the algorithm
> >
> > drivers/crypto/bfin_crc.c | 18 +++++++++---------
> > 1 file changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/crypto/bfin_crc.c b/drivers/crypto/bfin_crc.c
> > index cea3e8c..892b6d2 100644
> > --- a/drivers/crypto/bfin_crc.c
> > +++ b/drivers/crypto/bfin_crc.c
> > @@ -665,19 +665,19 @@ static int bfin_crypto_crc_probe(struct
> > platform_device *pdev) if (timeout == 0)
> > dev_info(&pdev->dev, "init crc poly timeout\n");
> >
> > + platform_set_drvdata(pdev, crc);
> > +
> > spin_lock(&crc_list.lock);
> > list_add(&crc->list, &crc_list.dev_list);
> > spin_unlock(&crc_list.lock);
> >
> > - platform_set_drvdata(pdev, crc);
> > -
> > - ret = crypto_register_ahash(&algs);
> > - if (ret) {
> > - spin_lock(&crc_list.lock);
> > - list_del(&crc->list);
> > - spin_unlock(&crc_list.lock);
> > - dev_err(&pdev->dev, "Cann't register crypto ahash device\n");
> > - goto out_error_dma;
> > + if (list_is_singular(&crc_list.dev_list)) {
> > + ret = crypto_register_ahash(&algs);
> > + if (ret) {
> > + dev_err(&pdev->dev,
> > + "Cann't register crypto ahash device\n");
>
> "Cann't" with two Ns ;-/
>
> Well, add "Reviewed-by: Marek Vasut <[email protected]>" into the next go please :)

Both patches applied and I've fixed the typo.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt