2013-03-14 09:48:21

by Chanho Min

[permalink] [raw]
Subject: [PATCH 0/2] lib,crypto: Add lz4 compressor module and crypto API

This patchset is for supporting LZ4 compression and the crypto API using it.
This should be applied after the previous Kyungsik's "LZ4 compressed kernel"
patches - https://lkml.org/lkml/2013/3/5/181.

As shown in bellow result, the size of data is a little bit bigger but
compressing speed is faster under the enabled unaligned memory access.
We can use lz4 de/compression through crypto API as well. Also,
It will be useful for another potential user of lz4 compression.

lz4 Compression Benchmark:
Compiler: ARM gcc 4.6.4
ARMv7, 1 GHz based board
Kernel: linux 3.4
Uncompressed data Size: 101 MB
Compressed Size compression Speed
LZO 72.1MB 32.1MB/s, 33.0MB/s(UA)
LZ4 75.1MB 30.4MB/s, 35.9MB/s(UA)
LZ4HC 59.8MB 2.4MB/s, 2.5MB/s(UA)
- UA: Unaligned memory Access support
- Latest patch set for LZO applied

Chanho Min (2):
lib: Add lz4 compressor module
crypto: Add lz4 Cryptographic API

crypto/Kconfig | 16 ++
crypto/Makefile | 2 +
crypto/lz4.c | 105 +++++++++
crypto/lz4hc.c | 105 +++++++++
include/linux/lz4.h | 36 ++++
lib/Kconfig | 6 +
lib/Makefile | 2 +
lib/lz4/Makefile | 2 +
lib/lz4/lz4_compress.c | 443 +++++++++++++++++++++++++++++++++++++
lib/lz4/lz4defs.h | 66 +++++-
lib/lz4/lz4hc_compress.c | 539 ++++++++++++++++++++++++++++++++++++++++++++++
11 files changed, 1320 insertions(+), 2 deletions(-)
create mode 100644 crypto/lz4.c
create mode 100644 crypto/lz4hc.c
create mode 100644 lib/lz4/lz4_compress.c
create mode 100644 lib/lz4/lz4hc_compress.c

--
1.7.9.5


2013-03-14 20:57:40

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 0/2] lib,crypto: Add lz4 compressor module and crypto API

On Thu, 14 Mar 2013 18:48:20 +0900 Chanho Min <[email protected]> wrote:

> This patchset is for supporting LZ4 compression and the crypto API using it.
> This should be applied after the previous Kyungsik's "LZ4 compressed kernel"
> patches - https://lkml.org/lkml/2013/3/5/181.

Thanks.

Yann, it would be appreciated if you could give us your Signed-off-by:
as an indication of your approval for including this code into Linux.
This is a bit of kernel legal bureaucracy which is explained at
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches?id=refs/tags/v3.9-rc2,
line 300.

2013-03-19 20:52:20

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 0/2] lib,crypto: Add lz4 compressor module and crypto API

On Tue, 19 Mar 2013 15:42:04 +0100 Yann Collet <[email protected]> wrote:

> Thanks for pointing that out.
> I've been looking into the document pointed by Andrew,
> and here is my understanding :
>
> Signed-off-by is a one-line, so in this case :
>
> Signed-off-by: Yann Collet <[email protected]>
>
>
> or
>
> Signed-off-by follows a declaration, in this case it might be :
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license
> indicated in the file;
>
>
> Signed-off-by: Yann Collet <[email protected]>
>
>
>
> Is that correct ?
> Should it be sent within this mailing list, or somewhere else ?

That's just fine - thanks!