2020-04-17 15:24:30

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: Tree for Apr 17 (drivers/char/hw_random/cctrng.c)

On 4/16/20 9:50 PM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20200416:
>


on i386:

../drivers/char/hw_random/cctrng.c: In function ?cc_trng_compwork_handler?:
../drivers/char/hw_random/cctrng.c:334:49: error: ?fips_enabled? undeclared (first use in this function); did you mean ?nx_enabled??
if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
^~~~~~~~~~~~
nx_enabled
../drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier is reported only once for each function it appears in
../drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of function ?fips_fail_notify?; did you mean ?sysfs_notify?? [-Werror=implicit-function-declaration]
fips_fail_notify();
^~~~~~~~~~~~~~~~
sysfs_notify


Full randconfig file is attached.

--
~Randy
Reported-by: Randy Dunlap <[email protected]>


Attachments:
config-r2152 (158.00 kB)

2020-04-17 20:15:29

by Hadar Gat

[permalink] [raw]
Subject: RE: linux-next: Tree for Apr 17 (drivers/char/hw_random/cctrng.c)

Hi Randy,
Thank you for reporting.
I will fix this issue shortly.
Hadar

> -----Original Message-----
> From: Randy Dunlap <[email protected]>
> Sent: Friday, 17 April 2020 18:23
> To: Stephen Rothwell <[email protected]>; Linux Next Mailing List
> <[email protected]>
> Cc: Linux Kernel Mailing List <[email protected]>; Linux Crypto
> Mailing List <[email protected]>; Hadar Gat
> <[email protected]>
> Subject: Re: linux-next: Tree for Apr 17 (drivers/char/hw_random/cctrng.c)
>
> On 4/16/20 9:50 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20200416:
> >
>
>
> on i386:
>
> ../drivers/char/hw_random/cctrng.c: In function
> ‘cc_trng_compwork_handler’:
> ../drivers/char/hw_random/cctrng.c:334:49: error: ‘fips_enabled’ undeclared
> (first use in this function); did you mean ‘nx_enabled’?
> if (CC_REG_FLD_GET(RNG_ISR, CRNGT_ERR, isr) && fips_enabled) {
> ^~~~~~~~~~~~
> nx_enabled
> ../drivers/char/hw_random/cctrng.c:334:49: note: each undeclared identifier
> is reported only once for each function it appears in
> ../drivers/char/hw_random/cctrng.c:335:3: error: implicit declaration of
> function ‘fips_fail_notify’; did you mean ‘sysfs_notify’? [-Werror=implicit-
> function-declaration]
> fips_fail_notify();
> ^~~~~~~~~~~~~~~~
> sysfs_notify
>
>
> Full randconfig file is attached.
>
> --
> ~Randy
> Reported-by: Randy Dunlap <[email protected]>