LinuxLists.cc - [PATCH] crypto: qat - add CRYPTO

2020-12-22 12:40:12

Subject: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies

This patch includes a missing dependency (CRYPTO_AES) which may
lead to an "undefined reference to `aes_expandkey'" linking error.

Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Marco Chiappero <[email protected]>
---
drivers/crypto/qat/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index beb379b23dc3..846a3d90b41a 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
+ select CRYPTO_AES
select FW_LOADER

config CRYPTO_DEV_QAT_DH895xCC
--
2.26.2

2020-12-23 07:53:39

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies

On Tue, Dec 22, 2020 at 01:00:24PM +0000, Marco Chiappero wrote:
> This patch includes a missing dependency (CRYPTO_AES) which may
> lead to an "undefined reference to `aes_expandkey'" linking error.
>
> Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Marco Chiappero <[email protected]>
> ---
> drivers/crypto/qat/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2020-12-23 18:43:14

by Ard Biesheuvel

[permalink] [raw]

Subject: Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies

On Tue, 22 Dec 2020 at 13:39, Marco Chiappero <[email protected]> wrote:
>
> This patch includes a missing dependency (CRYPTO_AES) which may
> lead to an "undefined reference to `aes_expandkey'" linking error.
>
> Fixes: 5106dfeaeabe ("crypto: qat - add AES-XTS support for QAT GEN4 devices")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Marco Chiappero <[email protected]>
> ---
> drivers/crypto/qat/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index beb379b23dc3..846a3d90b41a 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> + select CRYPTO_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>

This should be 'select CRYPTO_LIB_AES'

2020-12-23 21:00:59

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies

On Wed, Dec 23, 2020 at 07:39:46PM +0100, Ard Biesheuvel wrote:
>
> This should be 'select CRYPTO_LIB_AES'

Please send a follow-up. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2021-01-04 15:16:24

by Marco Chiappero

[permalink] [raw]

Subject: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
common code.

Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
Reported-by: Ard Biesheuvel <[email protected]>
Signed-off-by: Marco Chiappero <[email protected]>
---
drivers/crypto/qat/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
index 846a3d90b41a..77783feb62b2 100644
--- a/drivers/crypto/qat/Kconfig
+++ b/drivers/crypto/qat/Kconfig
@@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
select CRYPTO_SHA1
select CRYPTO_SHA256
select CRYPTO_SHA512
- select CRYPTO_AES
+ select CRYPTO_LIB_AES
select FW_LOADER

config CRYPTO_DEV_QAT_DH895xCC
--
2.26.2

2021-01-04 15:19:25

by Marco Chiappero

[permalink] [raw]

Subject: RE: [PATCH] crypto: qat - add CRYPTO_AES to Kconfig dependencies

> On Tue, 22 Dec 2020 at 13:39, Marco Chiappero <[email protected]>
> wrote:
>
> > diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> > index beb379b23dc3..846a3d90b41a 100644
> > --- a/drivers/crypto/qat/Kconfig
> > +++ b/drivers/crypto/qat/Kconfig
> > @@ -11,6 +11,7 @@ config CRYPTO_DEV_QAT
> > select CRYPTO_SHA1
> > select CRYPTO_SHA256
> > select CRYPTO_SHA512
> > + select CRYPTO_AES
> > select FW_LOADER
> >
> > config CRYPTO_DEV_QAT_DH895xCC
> > --
> > 2.26.2
> >
>
> This should be 'select CRYPTO_LIB_AES'

Thank you for bringing this up.

Regards,
Marco

2021-01-04 15:49:16

by Ard Biesheuvel

[permalink] [raw]

Subject: Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

On Mon, 4 Jan 2021 at 16:13, Marco Chiappero <[email protected]> wrote:
>
> Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
> common code.
>
> Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
> Reported-by: Ard Biesheuvel <[email protected]>
> Signed-off-by: Marco Chiappero <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> drivers/crypto/qat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index 846a3d90b41a..77783feb62b2 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> - select CRYPTO_AES
> + select CRYPTO_LIB_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>

2021-01-04 17:06:09

by Cabiddu, Giovanni

[permalink] [raw]

Subject: Re: [PATCH] crypto: qat - replace CRYPTO_AES with CRYPTO_LIB_AES in Kconfig

On Mon, Jan 04, 2021 at 03:35:15PM +0000, Marco Chiappero wrote:
> Use CRYPTO_LIB_AES in place of CRYPTO_AES in the dependences for the QAT
> common code.
>
> Fixes: c0e583ab2016 ("crypto: qat - add CRYPTO_AES to Kconfig dependencies")
> Reported-by: Ard Biesheuvel <[email protected]>
> Signed-off-by: Marco Chiappero <[email protected]>

Reviewed-by: Giovanni Cabiddu <[email protected]>

> ---
> drivers/crypto/qat/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig
> index 846a3d90b41a..77783feb62b2 100644
> --- a/drivers/crypto/qat/Kconfig
> +++ b/drivers/crypto/qat/Kconfig
> @@ -11,7 +11,7 @@ config CRYPTO_DEV_QAT
> select CRYPTO_SHA1
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> - select CRYPTO_AES
> + select CRYPTO_LIB_AES
> select FW_LOADER
>
> config CRYPTO_DEV_QAT_DH895xCC
> --
> 2.26.2
>

2021-01-14 06:47:46

by Herbert Xu

[permalink] [raw]