2021-12-30 07:03:59

by Zizhuang Deng

Subject: [PATCH] lib/mpi: Add the return value check of kcalloc()

Add the return value check of kcalloc() to avoid potential
NULL ptr dereference.

Signed-off-by: Zizhuang Deng <[email protected]>
---
lib/mpi/mpi-mod.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
index 47bc59edd4ff..54fcc01564d9 100644
--- a/lib/mpi/mpi-mod.c
+++ b/lib/mpi/mpi-mod.c
@@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)

mpi_normalize(m);
ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
+ if (!ctx)
+ return NULL;

if (copy) {
ctx->m = mpi_copy(m);
--
2.25.1

2021-12-30 07:26:45

by Tianjia Zhang

Subject: Re: [PATCH] lib/mpi: Add the return value check of kcalloc()

On 12/30/21 3:03 PM, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <[email protected]>
> ---

Reviewed-by: Tianjia Zhang <[email protected]>

Best regards,
Tianjia

> lib/mpi/mpi-mod.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/mpi/mpi-mod.c b/lib/mpi/mpi-mod.c
> index 47bc59edd4ff..54fcc01564d9 100644
> --- a/lib/mpi/mpi-mod.c
> +++ b/lib/mpi/mpi-mod.c
> @@ -40,6 +40,8 @@ mpi_barrett_t mpi_barrett_init(MPI m, int copy)
>
> mpi_normalize(m);
> ctx = kcalloc(1, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return NULL;
>
> if (copy) {
> ctx->m = mpi_copy(m);

2022-01-07 03:33:57

by Herbert Xu

Subject: Re: [PATCH] lib/mpi: Add the return value check of kcalloc()

On Thu, Dec 30, 2021 at 03:03:31PM +0800, Zizhuang Deng wrote:
> Add the return value check of kcalloc() to avoid potential
> NULL ptr dereference.
>
> Signed-off-by: Zizhuang Deng <[email protected]>
> ---
> lib/mpi/mpi-mod.c | 2 ++
> 1 file changed, 2 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt