2022-02-10 19:28:30

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: crypto: convert rockchip-crypto to yaml

On 10/02/2022 17:14, Corentin Labbe wrote:
> Convert rockchip-crypto to yaml
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> Change since v1:
> - fixed example
> - renamed to a new name
> - fixed some maxItems
>
> .../crypto/rockchip,rk3288-crypto.yaml | 66 +++++++++++++++++++
> .../bindings/crypto/rockchip-crypto.txt | 28 --------
> 2 files changed, 66 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> new file mode 100644
> index 000000000000..44f415597e32
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip,rk3288-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip Electronics And Security Accelerator
> +
> +maintainers:
> + - Corentin Labbe <[email protected]>

You removed Heiko. It's fine for me, just is it expected?

Look good to me.

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-02-10 23:36:29

by Corentin LABBE

Subject: Re: [PATCH v2] dt-bindings: crypto: convert rockchip-crypto to yaml

Le Thu, Feb 10, 2022 at 05:19:50PM +0100, Krzysztof Kozlowski a ?crit :
> On 10/02/2022 17:14, Corentin Labbe wrote:
> > Convert rockchip-crypto to yaml
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > Change since v1:
> > - fixed example
> > - renamed to a new name
> > - fixed some maxItems
> >
> > .../crypto/rockchip,rk3288-crypto.yaml | 66 +++++++++++++++++++
> > .../bindings/crypto/rockchip-crypto.txt | 28 --------
> > 2 files changed, 66 insertions(+), 28 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> > new file mode 100644
> > index 000000000000..44f415597e32
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/crypto/rockchip,rk3288-crypto.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip Electronics And Security Accelerator
> > +
> > +maintainers:
> > + - Corentin Labbe <[email protected]>
>
> You removed Heiko. It's fine for me, just is it expected?
>

This is an error I fixed manualy in v1 file and forgot to change and commit...

Sorry
I will resend a new version later