2022-05-02 10:00:33

by Uwe Kleine-König

Subject: [PATCH] crypto: atmel-i2c - Simplify return code in probe function

There is no semantical change introduced by this change.

Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/crypto/atmel-i2c.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
index 6fd3e969211d..384865ef96ce 100644
--- a/drivers/crypto/atmel-i2c.c
+++ b/drivers/crypto/atmel-i2c.c
@@ -364,11 +364,7 @@ int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)

i2c_set_clientdata(client, i2c_priv);

- ret = device_sanity_check(client);
- if (ret)
- return ret;
-
- return 0;
+ return device_sanity_check(client);
}
EXPORT_SYMBOL(atmel_i2c_probe);

--
2.35.1

2022-05-04 17:40:24

by Claudiu Beznea

Subject: Re: [PATCH] crypto: atmel-i2c - Simplify return code in probe function

On 29.04.2022 17:03, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> There is no semantical change introduced by this change.
>
> Signed-off-by: Uwe Kleine-König <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>


> ---
> drivers/crypto/atmel-i2c.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c
> index 6fd3e969211d..384865ef96ce 100644
> --- a/drivers/crypto/atmel-i2c.c
> +++ b/drivers/crypto/atmel-i2c.c
> @@ -364,11 +364,7 @@ int atmel_i2c_probe(struct i2c_client *client, const struct i2c_device_id *id)
>
> i2c_set_clientdata(client, i2c_priv);
>
> - ret = device_sanity_check(client);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return device_sanity_check(client);
> }
> EXPORT_SYMBOL(atmel_i2c_probe);
>
> --
> 2.35.1
>

2022-05-07 18:14:41

by Herbert Xu

Subject: Re: [PATCH] crypto: atmel-i2c - Simplify return code in probe function

On Fri, Apr 29, 2022 at 04:03:49PM +0200, Uwe Kleine-K?nig wrote:
> There is no semantical change introduced by this change.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
> ---
> drivers/crypto/atmel-i2c.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt