On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <[email protected]> wrote:
>
> On 2/25/2020 6:12 PM, André Draszik wrote:
> > The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
> >
> > This driver here should only return IRQ_HANDLED if the status register
> > indicates that the event we're handling in the irq handler was genuinely
> > intended for this driver. Otheriwse the interrupt subsystem will
> > assume the interrupt was handled successfully even though it wasn't
> > at all.
> >
> > Signed-off-by: André Draszik <[email protected]>
> > Cc: "Horia Geantă" <[email protected]>
> > Cc: Aymen Sghaier <[email protected]>
> > Cc: Herbert Xu <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Rob Herring <[email protected]>
> > Cc: Mark Rutland <[email protected]>
> > Cc: Shawn Guo <[email protected]>
> > Cc: Sascha Hauer <[email protected]>
> > Cc: Pengutronix Kernel Team <[email protected]>
> > Cc: Fabio Estevam <[email protected]>
> > Cc: NXP Linux Team <[email protected]>
> > Cc: Dmitry Torokhov <[email protected]>
> > Cc: Anson Huang <[email protected]>
> > Cc: Robin Gong <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> For patches 2-6:
> Reviewed-by: Horia Geantă <[email protected]>
>
> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated.
Is there an update coming for the 8mn family? I am seeing it not wake
from the power key, and I was hoping to resolve that before i make a
push to submit a new 8MN board for review.
thanks
adam
>
> Thanks,
> Horia
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 3/28/2020 5:43 AM, Adam Ford wrote:
> On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <[email protected]> wrote:
>>
>> On 2/25/2020 6:12 PM, André Draszik wrote:
>>> The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
>>>
>>> This driver here should only return IRQ_HANDLED if the status register
>>> indicates that the event we're handling in the irq handler was genuinely
>>> intended for this driver. Otheriwse the interrupt subsystem will
>>> assume the interrupt was handled successfully even though it wasn't
>>> at all.
>>>
>>> Signed-off-by: André Draszik <[email protected]>
>>> Cc: "Horia Geantă" <[email protected]>
>>> Cc: Aymen Sghaier <[email protected]>
>>> Cc: Herbert Xu <[email protected]>
>>> Cc: "David S. Miller" <[email protected]>
>>> Cc: Rob Herring <[email protected]>
>>> Cc: Mark Rutland <[email protected]>
>>> Cc: Shawn Guo <[email protected]>
>>> Cc: Sascha Hauer <[email protected]>
>>> Cc: Pengutronix Kernel Team <[email protected]>
>>> Cc: Fabio Estevam <[email protected]>
>>> Cc: NXP Linux Team <[email protected]>
>>> Cc: Dmitry Torokhov <[email protected]>
>>> Cc: Anson Huang <[email protected]>
>>> Cc: Robin Gong <[email protected]>
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>>> Cc: [email protected]
>> For patches 2-6:
>> Reviewed-by: Horia Geantă <[email protected]>
>>
>> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated.
>
> Is there an update coming for the 8mn family? I am seeing it not wake
> from the power key, and I was hoping to resolve that before i make a
> push to submit a new 8MN board for review.
>
Starting with linux-next next-20200320, there's commit
arm64: dts: imx8mn: Add snvs clock to powerkey
Could you confirm you've tested with a tree including it?
Thanks,
Horia
Hi Herbert, Dmitry,
On 4/1/2020 11:58 AM, Horia Geanta wrote:
> On 3/28/2020 5:43 AM, Adam Ford wrote:
>> On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <[email protected]> wrote:
>>>
>>> On 2/25/2020 6:12 PM, André Draszik wrote:
>>>> The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
>>>>
>>>> This driver here should only return IRQ_HANDLED if the status register
>>>> indicates that the event we're handling in the irq handler was genuinely
>>>> intended for this driver. Otheriwse the interrupt subsystem will
>>>> assume the interrupt was handled successfully even though it wasn't
>>>> at all.
>>>>
>>>> Signed-off-by: André Draszik <[email protected]>
>>>> Cc: "Horia Geantă" <[email protected]>
>>>> Cc: Aymen Sghaier <[email protected]>
>>>> Cc: Herbert Xu <[email protected]>
>>>> Cc: "David S. Miller" <[email protected]>
>>>> Cc: Rob Herring <[email protected]>
>>>> Cc: Mark Rutland <[email protected]>
>>>> Cc: Shawn Guo <[email protected]>
>>>> Cc: Sascha Hauer <[email protected]>
>>>> Cc: Pengutronix Kernel Team <[email protected]>
>>>> Cc: Fabio Estevam <[email protected]>
>>>> Cc: NXP Linux Team <[email protected]>
>>>> Cc: Dmitry Torokhov <[email protected]>
>>>> Cc: Anson Huang <[email protected]>
>>>> Cc: Robin Gong <[email protected]>
>>>> Cc: [email protected]
>>>> Cc: [email protected]
>>>> Cc: [email protected]
>>>> Cc: [email protected]
>>> For patches 2-6:
>>> Reviewed-by: Horia Geantă <[email protected]>
>>>
>>> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated.
>>
>> Is there an update coming for the 8mn family? I am seeing it not wake
>> from the power key, and I was hoping to resolve that before i make a
>> push to submit a new 8MN board for review.
>>
> Starting with linux-next next-20200320, there's commit
> arm64: dts: imx8mn: Add snvs clock to powerkey
>
> Could you confirm you've tested with a tree including it?
>
Seems that from this series:
https://lore.kernel.org/linux-crypto/[email protected]/T/
only DT patches (2,3,4) were applied.
Would it be ok to go via crypto tree with:
[PATCH v2 1/6] dt-bindings: crypto: fsl-sec4: add snvs clock to pwrkey
and via input tree with:
[PATCH v2 5/6] Input: snvs_pwrkey - enable snvs clock as needed
[PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events
?
Thanks,
Horia