2023-07-13 09:03:02

by chenqingyun001

Subject: [PATCH] crypto:space required before the open brace '{'

Maintain code readability and style consistency

Signed-off-by: Qingyun Chen <[email protected]>
---
arch/arm64/crypto/ghash-ce-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/ghash-ce-glue.c
b/arch/arm64/crypto/ghash-ce-glue.c
index 97331b454ea8..cb1cd161c022 100644
--- a/arch/arm64/crypto/ghash-ce-glue.c
+++ b/arch/arm64/crypto/ghash-ce-glue.c
@@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm,
const u8 *inkey,
if (ret)
return -EINVAL;

- aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
+ aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});

/* needed for the fallback */
memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);

2023-07-13 09:55:07

by Ard Biesheuvel

Subject: Re: [PATCH] crypto:space required before the open brace '{'

On Thu, 13 Jul 2023 at 10:59, <[email protected]> wrote:
>
> Maintain code readability and style consistency
>
> Signed-off-by: Qingyun Chen <[email protected]>

NAK

This is a cast operation, which doesn't require a trailing space.

If the tool you are using misidentifies this, please fix the tool instead.


> ---
> arch/arm64/crypto/ghash-ce-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/ghash-ce-glue.c
> b/arch/arm64/crypto/ghash-ce-glue.c
> index 97331b454ea8..cb1cd161c022 100644
> --- a/arch/arm64/crypto/ghash-ce-glue.c
> +++ b/arch/arm64/crypto/ghash-ce-glue.c
> @@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm,
> const u8 *inkey,
> if (ret)
> return -EINVAL;
>
> - aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
> + aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});
>
> /* needed for the fallback */
> memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);