2007-11-21 21:17:32

by Tan Swee Heng

[permalink] [raw]
Subject: [PATCH 2/3] salsa20_i586: Salsa20 stream cipher algorithm (i586 version)

This patch implements the glue code that uses the Salsa20 x86-pm
assembly code written by D. J. Bernstein.
Original assembly code is available at
<http://cr.yp.to/snuffle/salsa20/x86-pm/salsa20.s>.

Signed-off-by: Tan Swee Heng <[email protected]>


2007-11-21 21:39:09

by Tan Swee Heng

[permalink] [raw]
Subject: Re: [PATCH 2/3] salsa20_i586: Salsa20 stream cipher algorithm (i586 version)

Forgot the attachment... again. :-)

On Nov 22, 2007 5:17 AM, Tan Swee Heng <[email protected]> wrote:
> This patch implements the glue code that uses the Salsa20 x86-pm
> assembly code written by D. J. Bernstein.
> Original assembly code is available at
> <http://cr.yp.to/snuffle/salsa20/x86-pm/salsa20.s>.
>
> Signed-off-by: Tan Swee Heng <[email protected]>
>


Attachments:
(No filename) (372.00 B)
patch2-salsa20_i586.txt (63.89 kB)
Download all attachments

2007-11-23 11:59:48

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 2/3] salsa20_i586: Salsa20 stream cipher algorithm (i586 version)

On Thu, Nov 22, 2007 at 05:39:07AM +0800, Tan Swee Heng wrote:
> Forgot the attachment... again. :-)
>
> On Nov 22, 2007 5:17 AM, Tan Swee Heng <[email protected]> wrote:
> > This patch implements the glue code that uses the Salsa20 x86-pm
> > assembly code written by D. J. Bernstein.
> > Original assembly code is available at
> > <http://cr.yp.to/snuffle/salsa20/x86-pm/salsa20.s>.
> >
> > Signed-off-by: Tan Swee Heng <[email protected]>

Could you please reformat this so that it's more in-line with
what's already in arch/x86/crypto? In particular, indentation
for the code would be nice :)

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2007-11-24 11:29:07

by Tan Swee Heng

[permalink] [raw]
Subject: Re: [PATCH 2/3] salsa20_i586: Salsa20 stream cipher algorithm (i586 version)

Hi Herbert,

On Nov 23, 2007 7:59 PM, Herbert Xu <[email protected]> wrote:
> Could you please reformat this so that it's more in-line with
> what's already in arch/x86/crypto? In particular, indentation
> for the code would be nice :)

I did not reformat the code because I wanted to use Bernstein's code
verbatim without change. This is to allow people who have validated
his code previously to use it without validation again. But I guess
there is no harm tidying it up too if it is just a matter of
indentation. I suppose I should retain his comments as well as it
helps in reading the assembly. Will resubmit when I am done.

Swee Heng