2007-11-27 23:31:32

by Tan Swee Heng

[permalink] [raw]
Subject: [PATCH 2/2] tcrypt.h: AES CTR large test vector

This patch adds a large AES CTR mode test vector. The test vector is
4100 bytes in size. It was generated using a C++ program that called
Crypto++.

Note that this patch increases considerably the size of "struct
cipher_testvec" and hence the size of tcrypt.ko.

Signed-off-by: Tan Swee Heng <[email protected]>

PS: I am not attaching the C++ program since it can be recreated from
the test vector's key, IV and plaintext. If required, I can always
post it here. I've also assumed that Crypto++'s implementation is
sufficiently different from what we have. Else the test vector check
will not be meaningful.


Attachments:
(No filename) (614.00 B)
patch2-aes_ctr_large_tv.txt (53.47 kB)
Download all attachments

2007-11-29 13:39:47

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH 2/2] tcrypt.h: AES CTR large test vector

On Wed, Nov 28, 2007 at 07:31:30AM +0800, Tan Swee Heng wrote:
> This patch adds a large AES CTR mode test vector. The test vector is
> 4100 bytes in size. It was generated using a C++ program that called
> Crypto++.
>
> Note that this patch increases considerably the size of "struct
> cipher_testvec" and hence the size of tcrypt.ko.
>
> Signed-off-by: Tan Swee Heng <[email protected]>

Patch applied. It's a good thing modules use vmalloc and tcrypt doesn't
have to stay loaded :)

Longer term we want to

1) Split tcrypt into core and algorithm-specific chunks. Have each
algorithm produce its own tcrypt module.

2) Change these staticly sized arrays to something a bit more flexible.

Hopefully your addition will actually prompt someone (other than me :)
to do these things.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt