From: Herbert Xu Subject: Re: [PATCH] [crypto] load the SHA1[1|256] module by an alias Date: Fri, 5 Oct 2007 16:57:44 +0800 Message-ID: <20071005085744.GC10959@gondor.apana.org.au> References: <200708200234.25620.ak@suse.de> <20070820101618.GE16680@bingen.suse.de> <20070820120605.GA13163@gondor.apana.org.au> <20070930124239.GB24811@Chamillionaire.breakpoint.cc> <20071003073522.GA7285@gondor.apana.org.au> <20071004083512.GA11305@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: Sebastian Siewior Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:1660 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754110AbXJEI5q (ORCPT ); Fri, 5 Oct 2007 04:57:46 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Thu, Oct 04, 2007 at 09:37:39AM +0200, Sebastian Siewior wrote: > Loading the crypto algorithm by the alias instead of by module directly > has the advantage that all possible implementations of this algorithm > are loaded automatically and the crypto API can choose the best one > depending on its priority. > Additionally it ensures that the generic implementation as well as the > HW driver (if available) is loaded in case the HW driver needs the > generic version as fallback in corner cases. > > Signed-off-by: Sebastian Siewior This patch is correct per se but it combined with the code in padlock-sha can cause a dead-lock. Padlock-sha tries to load the generic sha module in its init function. At this point it is still holding the module_mutex so the probe will dead-lock. The probe is actually pointless since we can always probe when the algorithm is actually used which does not lead to dead-locks like this. So please delete the padlock_sha_check_fallbacks code in your patch to make it load correctly. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt