From: Herbert Xu Subject: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops Date: Tue, 30 Oct 2007 08:08:27 +0800 Message-ID: <20071030000827.GA9037@gondor.apana.org.au> References: <20071026145905.GA13850@gondor.apana.org.au> <20071029201627.GD7499@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Linux Kernel Mailing List , Linux Crypto Mailing List , netdev@vger.kernel.org To: Jens Axboe Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:1307 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752873AbXJ3AJ3 (ORCPT ); Mon, 29 Oct 2007 20:09:29 -0400 Content-Disposition: inline In-Reply-To: <20071029201627.GD7499@kernel.dk> Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote: > On Fri, Oct 26 2007, Herbert Xu wrote: > > [CRYPTO] tcrypt: Move sg_init_table out of timing loops > > > > This patch moves the sg_init_table out of the timing loops for hash > > algorithms so that it doesn't impact on the speed test results. > > Wouldn't it be better to just make sg_init_one() call sg_init_table? This looks fine to me although I think it's orthogonal to the patch you were quoting :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt